Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: migrate build to snapbox #14068

Merged
merged 2 commits into from
Jun 21, 2024
Merged

test: migrate build to snapbox #14068

merged 2 commits into from
Jun 21, 2024

Conversation

weihanglo
Copy link
Member

What does this PR try to resolve?

Part of #14039.

Migrate tests/testsuite/build.rs to snapbox.

How should we test and review this PR?

Additional information

@rustbot
Copy link
Collaborator

rustbot commented Jun 14, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 14, 2024
weihanglo
weihanglo commented Jun 14, 2024
View reviewed changes
tests/testsuite/build.rs Show resolved Hide resolved
tests/testsuite/build.rs Show resolved Hide resolved
tests/testsuite/build.rs Show resolved Hide resolved
tests/testsuite/build.rs Show resolved Hide resolved
tests/testsuite/build.rs Show resolved Hide resolved
tests/testsuite/build.rs Show resolved Hide resolved
tests/testsuite/build.rs Show resolved Hide resolved
tests/testsuite/build.rs Show resolved Hide resolved
tests/testsuite/build.rs Show resolved Hide resolved
tests/testsuite/build.rs Show resolved Hide resolved
weihanglo
weihanglo commented Jun 14, 2024
View reviewed changes
tests/testsuite/build.rs Outdated Show resolved Hide resolved
@weihanglo weihanglo mentioned this pull request Jun 14, 2024
Closed
epage
epage reviewed Jun 14, 2024
View reviewed changes
tests/testsuite/build.rs Outdated Show resolved Hide resolved
epage
epage reviewed Jun 14, 2024
View reviewed changes
tests/testsuite/build.rs Outdated Show resolved Hide resolved
epage
epage reviewed Jun 14, 2024
View reviewed changes
tests/testsuite/build.rs Outdated Show resolved Hide resolved
epage
epage reviewed Jun 14, 2024
View reviewed changes
tests/testsuite/build.rs Outdated Show resolved Hide resolved
epage
epage reviewed Jun 14, 2024
View reviewed changes
tests/testsuite/build.rs
Comment on lines +5960 to 5933
#[allow(deprecated)]
#[cargo_test]
fn targets_selected_default() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an example of a test that uses does_not_contain in a way that I don't trust. It is hard coding specific rust flags and assuming from the lack of that that different targets aren't being built.

Unsure what to do about it though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A non-auto-updatable snapshot would help? So that people won't update it accidentally.

@epage
Copy link
Contributor

epage commented Jun 14, 2024

btw if you happen to notice a test could use check instead, that would be a great improvement!

@weihanglo
Copy link
Member Author

btw if you happen to notice a test could use check instead, that would be a great improvement!

I am tempted to, but the fact they are under testsuite/build.rs makes me think they should stay at cargo build. @Muscraft has done that effort a while ago. Maybe they know some details.

@weihanglo weihanglo mentioned this pull request Jun 15, 2024
Merged
@epage
Copy link
Contributor

epage commented Jun 21, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jun 21, 2024

📌 Commit c63286f has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2024
@bors
Copy link
Contributor

bors commented Jun 21, 2024

⌛ Testing commit c63286f with merge e35cd55...

@bors
Copy link
Contributor

bors commented Jun 21, 2024

☀️ Test successful - checks-actions
Approved by: epage
Pushing e35cd55 to master...

@bors bors merged commit e35cd55 into rust-lang:master Jun 21, 2024
22 checks passed
@bors bors mentioned this pull request Jun 21, 2024
Closed
@weihanglo weihanglo mentioned this pull request Jun 22, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 22, 2024
@bors
Auto merge of rust-lang#126816 - weihanglo:update-cargo, r=weihanglo
f1b0d54 
Update cargo

17 commits in 3ed207e416fb2f678a40cc79c02dcf4f936a21ce..bc89bffa5987d4af8f71011c7557119b39e44a65
2024-06-18 19:18:22 +0000 to 2024-06-22 00:36:36 +0000
- test: migrate weak_dep_features, workspaces and yank to snapbox (rust-lang/cargo#14111)
- test: migrate features and features(2|_namespaced) to snapbox (rust-lang/cargo#14100)
- test: Add auto-redaction for not found error (rust-lang/cargo#14124)
- test: migrate build to snapbox (rust-lang/cargo#14068)
- test: migrate unit_graph, update and vendor to snapbox (rust-lang/cargo#14119)
- fix(test): Un-redact Packaged files (rust-lang/cargo#14123)
- test: Auto-redact file number (rust-lang/cargo#14121)
- test: migrate lints_table and lints/(mod|unknown_lints) to snapbox (rust-lang/cargo#14104)
- Simplify checking feature syntax (rust-lang/cargo#14106)
- test: migrate testsuites to snapbox (rust-lang/cargo#14091)
- Make `-Cmetadata` consistent across platforms (rust-lang/cargo#14107)
- fix(toml): Warn when edition is unuset, even when MSRV is unset (rust-lang/cargo#14110)
- Add `CodeFix::apply_solution` and impl `Clone` (rust-lang/cargo#14092)
- test: migrate `cargo_alias_config&cargo_config/mod` to snapbox (rust-lang/cargo#14093)
- Simplify checking for dependency cycles (rust-lang/cargo#14089)
- test: Migrate `pub_priv.rs` to snapshot (rust-lang/cargo#14103)
- test: migrate rustdoc and rustdocflags to snapbox (rust-lang/cargo#14098)

<!--
r? ghost
-->
@rustbot rustbot added this to the 1.81.0 milestone Jun 22, 2024
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jun 23, 2024
@bors
Auto merge of #126816 - weihanglo:update-cargo, r=weihanglo
c38d856 
Update cargo

17 commits in 3ed207e416fb2f678a40cc79c02dcf4f936a21ce..bc89bffa5987d4af8f71011c7557119b39e44a65
2024-06-18 19:18:22 +0000 to 2024-06-22 00:36:36 +0000
- test: migrate weak_dep_features, workspaces and yank to snapbox (rust-lang/cargo#14111)
- test: migrate features and features(2|_namespaced) to snapbox (rust-lang/cargo#14100)
- test: Add auto-redaction for not found error (rust-lang/cargo#14124)
- test: migrate build to snapbox (rust-lang/cargo#14068)
- test: migrate unit_graph, update and vendor to snapbox (rust-lang/cargo#14119)
- fix(test): Un-redact Packaged files (rust-lang/cargo#14123)
- test: Auto-redact file number (rust-lang/cargo#14121)
- test: migrate lints_table and lints/(mod|unknown_lints) to snapbox (rust-lang/cargo#14104)
- Simplify checking feature syntax (rust-lang/cargo#14106)
- test: migrate testsuites to snapbox (rust-lang/cargo#14091)
- Make `-Cmetadata` consistent across platforms (rust-lang/cargo#14107)
- fix(toml): Warn when edition is unuset, even when MSRV is unset (rust-lang/cargo#14110)
- Add `CodeFix::apply_solution` and impl `Clone` (rust-lang/cargo#14092)
- test: migrate `cargo_alias_config&cargo_config/mod` to snapbox (rust-lang/cargo#14093)
- Simplify checking for dependency cycles (rust-lang/cargo#14089)
- test: Migrate `pub_priv.rs` to snapshot (rust-lang/cargo#14103)
- test: migrate rustdoc and rustdocflags to snapbox (rust-lang/cargo#14098)

<!--
r? ghost
-->
@weihanglo weihanglo deleted the snapbox-build branch July 9, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epage epage epage left review comments

Assignees

@epage epage

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
4 participants
@weihanglo @rustbot @epage @bors