Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New names #142

Merged
merged 2 commits into from
Jul 8, 2014
Merged

New names #142

merged 2 commits into from
Jul 8, 2014

Conversation

wycats
Copy link
Contributor

@wycats wycats commented Jul 8, 2014

This PR moves Cargo over to the new naming based on RFC 35.

  • You should no longer use #[crate_name] or #[crate_id] in any crate managed by Cargo.
  • You no longer need a [[lib]] section in your Cargo.toml if you name your library src/lib.rs.
  • You no longer need a [[bin]] section in your Cargo.toml if you name your library src/main.rs.
  • You can include multiple [[bins]] in src/bin/*.rs and Cargo will treat them as if they were specified via [[bin]].

This commit does not yet add support for -C metadata or -C extra-file-name, but that is coming soon.

@huonw
Copy link
Member

huonw commented Jul 8, 2014

You can include multiple [[bins]] in src/bin/*.rs and Cargo will treat them as if they were specified via [[bin]].

To be clear, this means you can just have the a file foo.rs in src/bin/ and cargo will just treat it as if it were a [[bin]] with name foo?

@alexcrichton
Copy link
Member

r=me if you tidy up the commit log and remove the dependency on libglob (you just need to use fs::readdir)

@alexcrichton
Copy link
Member

To be clear, this means you can just have the a file foo.rs in src/bin/ and cargo will just treat it as if it were a [[bin]] with name foo?

That is correct!

alexcrichton
alexcrichton reviewed Jul 8, 2014
View reviewed changes
src/cargo/util/toml.rs
}

// TODO: glob takes a &str even though Paths may have non-UTF8 chars. This
// seems like a bug in libglob
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment seems out of date

bors added a commit that referenced this pull request Jul 8, 2014
@bors
auto merge of #142 : rust-lang/cargo/new-names, r=alexcrichton
7d870dd 
This PR moves Cargo over to the new naming based on [RFC 35](https://github.com/rust-lang/rfcs/blob/master/complete/0035-remove-crate-id.md).

* You should no longer use `#[crate_name]` or `#[crate_id]` in any crate managed by Cargo.
* You no longer need a `[[lib]]` section in your `Cargo.toml` if you name your library `src/lib.rs`.
* You no longer need a `[[bin]]` section in your `Cargo.toml` if you name your library `src/main.rs`.
* You can include multiple `[[bins]]` in `src/bin/*.rs` and Cargo will treat them as if they were specified via `[[bin]]`.

This commit does not yet add support for `-C metadata` or `-C extra-file-name`, but that is coming soon.
@bors bors merged commit 56879e5 into master Jul 8, 2014
@wycats wycats deleted the new-names branch July 9, 2014 21:52
bors added a commit to alexcrichton/cargo that referenced this pull request Sep 2, 2014
@bors
auto merge of rust-lang#142 : rust-lang/cargo/new-names, r=alexcrichton
a6061db 
This PR moves Cargo over to the new naming based on [RFC 35](https://github.com/rust-lang/rfcs/blob/master/complete/0035-remove-crate-id.md).

* You should no longer use `#[crate_name]` or `#[crate_id]` in any crate managed by Cargo.
* You no longer need a `[[lib]]` section in your `Cargo.toml` if you name your library `src/lib.rs`.
* You no longer need a `[[bin]]` section in your `Cargo.toml` if you name your library `src/main.rs`.
* You can include multiple `[[bins]]` in `src/bin/*.rs` and Cargo will treat them as if they were specified via `[[bin]]`.

This commit does not yet add support for `-C metadata` or `-C extra-file-name`, but that is coming soon.
bors added a commit that referenced this pull request Sep 24, 2019
@bors
Auto merge of #7422 - rust-lang:dependabot/cargo/env_logger-0.7.0, r=…
068a9b6 
…Eh2406

Update env_logger requirement from 0.6.0 to 0.7.0

Updates the requirements on [env_logger](https://github.com/sebasmagri/env_logger) to permit the latest version.
<details>
<summary>Release notes</summary>

*Sourced from [env_logger's releases](https://github.com/sebasmagri/env_logger/releases).*

> ## 0.7.0
> # Key Changes
>
> - Indent multiline messages by default
> - Support more timestamp precision
> - Update to the 2018 edition
>
> # Changes to minimum Rust
>
> The minimum version of Rust required has been set at `1.31.0`. We may change this in patch versions, but will always flag it in the release notes here.
>
> You can always check the `.travis.yml` file to see the current minimum supported version.
>
> # Contributions
>
> - [@&#8203;95ulisse](https://github.com/95ulisse) [Indentation for multiline log messages](https://github-redirect.dependabot.com/sebasmagri/env_logger/pull/134)
> - [@&#8203;oherrala](https://github.com/oherrala) [Add more timestamp precisions](https://github-redirect.dependabot.com/sebasmagri/env_logger/pull/140)
> - [Update to 2018 edition](https://github-redirect.dependabot.com/sebasmagri/env_logger/pull/142)
</details>
<details>
<summary>Commits</summary>

- [`424f031`](rust-cli/env_logger@424f031) Merge pull request [#143](https://github-redirect.dependabot.com/sebasmagri/env_logger/issues/143) from KodrAus/cargo/0.7.0
- [`058655e`](rust-cli/env_logger@058655e) prepare for 0.7.0 release
- [`bfac641`](rust-cli/env_logger@bfac641) Merge pull request [#142](https://github-redirect.dependabot.com/sebasmagri/env_logger/issues/142) from KodrAus/feat/2018
- [`ef10fa5`](rust-cli/env_logger@ef10fa5) use specific log version
- [`dc65e48`](rust-cli/env_logger@dc65e48) bump msrv to 1.31.0 for editions
- [`8209524`](rust-cli/env_logger@8209524) update to 2018 edition
- [`7105e63`](rust-cli/env_logger@7105e63) make breaking changes to timestamp API
- [`75911d7`](rust-cli/env_logger@75911d7) Merge pull request [#140](https://github-redirect.dependabot.com/sebasmagri/env_logger/issues/140) from oherrala/timestamp-formats
- [`95cd4ed`](rust-cli/env_logger@95cd4ed) Trick the compiler to think we are using timestamp
- [`92a5b2d`](rust-cli/env_logger@92a5b2d) Add more timestamp precisions
- Additional commits viewable in [compare view](rust-cli/env_logger@v0.6.0...v0.7.0)
</details>
<br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
ehuss pushed a commit to ehuss/cargo that referenced this pull request Nov 19, 2023
@alexcrichton
Merge pull request rust-lang#142 from light4/master
ef816e0 
Update transitioning url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wycats @huonw @alexcrichton @bors @tilde-engineering