[beta-1.81] Fix: cargo package failed on bare commit git repo.
#14374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: `cargo package` failed on bare commit git repo. ### What does this PR try to resolve? Fixes rust-lang#14354 This approach chose to not generate a `.cargo_vcs_info.json` for bare commit git repo. ### How should we test and review this PR? Compare the test changes before and after the two commits ### Additional information
|
rustbot
added
Command-package
S-waiting-on-review
weihanglo
force-pushed
the
beta-backport
branch
from
397b3df
to
4261a9d
Compare
|
Whats the reason for backporting this? Empty git repos seems like a pretty rare use case. |
True but
Fine with not backporting it. Whoever does this should find any workaround easily (like making a git commit). Closing. |
|
FWIW not backporting this has broken the crates.io smoke test setup (https://github.com/rust-lang/crates.io/blob/main/crates/crates_io_smoke_test/). we're basically doing the same "steps" as in #14354 (comment) leading to the "revspec 'HEAD' not found" error :-/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beta backports
cargo packagefailed on bare commit git repo. #14359In order to make CI pass, the following PRs are also cherry-picked:
build_std::{cross_custom,custom_test_framework,remap_path_scope}tests (see also [beta-1.81] fix(vendor): Strip excluded build targets #14368)