test: Migrate some json tests to snapbox #14402
Conversation
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
rustbot
added
the
S-waiting-on-review
| @@ -1879,24 +1879,25 @@ fn doc_message_format() { | |||
|
|
|||
| p.cargo("doc --message-format=json") | |||
| .with_status(101) | |||
| .with_json_contains_unordered( | |||
There was a problem hiding this comment.
Does the snapbox patch now correctly handle unordered JSON lines, or this test doesn't need unordered assertion?
There was a problem hiding this comment.
If by "now correctly" you mean "implicitly", then no, as that would not be correct. I am not seeing anything in this test case that needs .unordered() applied.
There was a problem hiding this comment.
I meant to comment under doc_json_artifacts but that one doesn't seem to need unordered either.
|
@bors r+ Thanks! |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Update cargo 8 commits in 2f738d617c6ead388f899802dd1a7fd66858a691..ba8b39413c74d08494f94a7542fe79aa636e1661 2024-08-13 10:57:52 +0000 to 2024-08-16 22:48:57 +0000 - feat(update): Report when incompatible-rust-version packages are selected (rust-lang/cargo#14401) - test: Migrate old_cargos to snapbox (rust-lang/cargo#14410) - Correct diagnostic for `TomlDebugInfo` (rust-lang/cargo#14413) - Add `--lockfile-path` flag (rust-lang/cargo#14326) - test: Migrate some json tests to snapbox (rust-lang/cargo#14402) - Implement base paths (RFC 3529) 1/n: path dep and patch support (rust-lang/cargo#14360) - doc: convert comments to rustdoc in workspace (rust-lang/cargo#14397) - Fix MSRV for workspace .package and .dependencies (rust-lang/cargo#14400) r? ghost
What does this PR try to resolve?
This is part of #14039
How should we test and review this PR?
Additional information
This was unblocked because of assert-rs/snapbox#358