Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resolve): Direct people to working around less optimal MSRV-resolver results #14543

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Sep 13, 2024

  1. Configuration menu
    Copy the full SHA
    c369821 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ed073c9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c41798a View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Configuration menu
    Copy the full SHA
    7aa43fa View commit details
    Browse the repository at this point in the history
  2. feat(resolve): Direct people to working around less optimal MSRV-reso…

    …lver results
    
    In discussing rust-lang#14414, the general problem of the resolver picking a
    version older than a package needs for its MSRV (or lack of one) because of the MSRV of
    other packages came up.
    This tries to patch over that problem by telling users that a dependency
    might be able to be newer than the resolver selected.
    
    The message is fairly generic and might be misread to be about any MSRV
    update which an MSRV `fallback` strategy allows, which would make the
    count off.
    The reason it is so generic is we don't know with precision why it was
    held back
    - Direct dependents may have a non-semver upper bound on the version as
      we aren't trying to unify the version requirements across direct
      dependents at this time
    - A dependency could have removed a feature without making a breaking
      change
      - This seems like it should instead be an error but thats a
        conversation for another day
    - ~~The user enabled `-Zminimal-versions`~~
      - This is now detected and the message skipped
    
    Note: separate from this, we may also print the status suffix for this
    case if the package was not selected for update (e.g. passing
    `--workspace`).
    epage committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    03d94f4 View commit details
    Browse the repository at this point in the history