WIP Add bin/cdylib/staticlib suffix for artifact deps #14658
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
Command-tree
S-waiting-on-review
| @@ -167,6 +167,14 @@ impl Package { | |||
| pub fn proc_macro(&self) -> bool { | |||
| self.targets().iter().any(|target| target.proc_macro()) | |||
| } | |||
| // TODO fix this. For now, just wanted it to return a plausible value. Must figure out why .kinds() returns a Vec. | |||
| /// Gets crate-type in { .., artifact = <crate-type> } of this package | |||
There was a problem hiding this comment.
This returns ArtifactKind of a package's dependencies, not the ArtifactKind of the package itself. This is why (bin/cdylib/staticlib) suffixes currently print on the wrong line.
- expected
+ actual
- foo v0.0.0 ([ROOT]/foo)
-└── bindep v0.0.0 (bin) ([ROOT]/foo/bindep)
+ foo v0.0.0 (bin) ([ROOT]/foo)
+ └── bindep v0.0.0 ([ROOT]/foo/bindep)
|
☔ The latest upstream changes (presumably #14593) made this pull request unmergeable. Please resolve the merge conflicts. |
What does this PR try to resolve?
This is an implementation of cargo tree as defined in #10593 (comment)
How should we test and review this PR?
Additional information
r? @weihanglo