Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): Allow dry-run of a non-bumped workspace #14847

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

epage
Copy link
Contributor

@epage epage commented Nov 21, 2024

What does this PR try to resolve?

A dry-run release process won't be bumping the versions, making it so it can't do a dry-run publish because the local/remote registries will collide. This switches it to give the local registry precedence over the remote registry to make the dry-run release process work.

Fixes #14789

How should we test and review this PR?

Additional information

@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2024

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 21, 2024
@epage epage force-pushed the publish branch 4 times, most recently from a115b25 to ad23d73 Compare November 21, 2024 21:50
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 21, 2024

@weihanglo: 🔑 Insufficient privileges: Not in reviewers

@weihanglo weihanglo added this pull request to the merge queue Nov 21, 2024
Merged via the queue into rust-lang:master with commit e444425 Nov 21, 2024
20 checks passed
@epage epage deleted the publish branch November 21, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't cargo publish --workspace --dry-run if the versions already exist
4 participants