Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(pgo): determine test runnability at compile time #14874

Merged
merged 1 commit into from
Nov 30, 2024
Merged

test(pgo): determine test runnability at compile time #14874

merged 1 commit into from
Nov 30, 2024
+3 −6

Conversation

weihanglo
Copy link
Member

What does this PR try to resolve?

Address #14859 (comment)

I found that detecting llvm-profdata requires more works, so do this first.

@rustbot
Copy link
Collaborator

rustbot commented Nov 30, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 30, 2024
Rustin170506
Rustin170506 approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! 👍

@epage epage added this pull request to the merge queue Nov 30, 2024
Merged via the queue into rust-lang:master with commit 0d730ac Nov 30, 2024
20 checks passed
@weihanglo weihanglo deleted the linux-only branch November 30, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@epage epage epage approved these changes

Assignees

@epage epage

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weihanglo @rustbot @epage @Rustin170506