-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(schema): Expose IndexPackage, the description of a package within a Registry Index
#15770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
IndexPackage and RegistryDependency to cargo-util-schemas for better modularityIndexPackage and RegistryDependency to cargo-util-schemas for better modularity
deb3072 to
0d54071
Compare
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
IndexPackage and RegistryDependency to cargo-util-schemas for better modularityIndexPackage and RegistryDependency to cargo-util-schemas for better modularity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔢 Self-check (PR reviewed by myself and ready for feedback)
-
Code compiles successfully
-
Unit tests added
-
All tests pass
-
Comments added where necessary
-
PR title and description updated
-
PR size is reasonable
…-schemas` for better modularity Signed-off-by: 0xPoe <techregister@pm.me>
…ncy` structs Signed-off-by: 0xPoe <techregister@pm.me>
0d54071 to
8811325
Compare
IndexPackage and RegistryDependency to cargo-util-schemas for better modularityIndexPackage, the description of a package within a Registry Index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for commit messages, the "refactor" is a "feature" commit for the schema
|
Thanks for your review! 💚 💙 💜 💛 ❤️ |
…hin a Registry Index (rust-lang#15770) ### What does this PR try to resolve? ref rust-lang#14834 In this pull request, I moved `IndexPackage` to `cargo-util-schemas` to enable third-party applications and `cargo-dev-registry` to utilize this common struct. For instance, crates.io has its own `IndexPackage` located at https://github.com/rust-lang/crates.io/blob/005667f0416d03932a50309db6cc672945b033fe/crates/crates_io_index/data.rs#L5. By moving it to `cargo-util-schemas`, we allow different applications to use this struct more easily. ### How to test and review this PR? It shouldn't break any tests; it's just a refactoring.
Update cargo 3 commits in a7fcef21feb4d835d1fee83b3f93b4aef86d5545..840b83a10fb0e039a83f4d70ad032892c287570a 2025-07-13 02:25:52 +0000 to 2025-07-30 13:59:19 +0000 - chore: fix some minor issues in comments (rust-lang/cargo#15787) - feat(schema): Expose `IndexPackage`, the description of a package within a Registry Index (rust-lang/cargo#15770) - chore: update toml/toml_edit to latest (rust-lang/cargo#15779) r? ghost
Update cargo 3 commits in a7fcef21feb4d835d1fee83b3f93b4aef86d5545..840b83a10fb0e039a83f4d70ad032892c287570a 2025-07-13 02:25:52 +0000 to 2025-07-30 13:59:19 +0000 - chore: fix some minor issues in comments (rust-lang/cargo#15787) - feat(schema): Expose `IndexPackage`, the description of a package within a Registry Index (rust-lang/cargo#15770) - chore: update toml/toml_edit to latest (rust-lang/cargo#15779) r? ghost
Update cargo 3 commits in a7fcef21feb4d835d1fee83b3f93b4aef86d5545..840b83a10fb0e039a83f4d70ad032892c287570a 2025-07-13 02:25:52 +0000 to 2025-07-30 13:59:19 +0000 - chore: fix some minor issues in comments (rust-lang/cargo#15787) - feat(schema): Expose `IndexPackage`, the description of a package within a Registry Index (rust-lang/cargo#15770) - chore: update toml/toml_edit to latest (rust-lang/cargo#15779) r? ghost
Update cargo 3 commits in a7fcef21feb4d835d1fee83b3f93b4aef86d5545..840b83a10fb0e039a83f4d70ad032892c287570a 2025-07-13 02:25:52 +0000 to 2025-07-30 13:59:19 +0000 - chore: fix some minor issues in comments (rust-lang/cargo#15787) - feat(schema): Expose `IndexPackage`, the description of a package within a Registry Index (rust-lang/cargo#15770) - chore: update toml/toml_edit to latest (rust-lang/cargo#15779) r? ghost
What does this PR try to resolve?
ref #14834
In this pull request, I moved
IndexPackagetocargo-util-schemasto enable third-party applications andcargo-dev-registryto utilize this common struct.For instance, crates.io has its own
IndexPackagelocated at https://github.com/rust-lang/crates.io/blob/005667f0416d03932a50309db6cc672945b033fe/crates/crates_io_index/data.rs#L5.By moving it to
cargo-util-schemas, we allow different applications to use this struct more easily.How to test and review this PR?
It shouldn't break any tests; it's just a refactoring.