Add retry for git fetch failures in CARGO_NET_GIT_FETCH_WITH_CLI path

[BiagioFesta]

What does this PR try to resolve?

#15856

This PR addresses transient failures when using the CARGO_NET_GIT_FETCH_WITH_CLI
path by adding support for marking process failures as spurious and enabling
retries for git fetch.

Changes

• Introduce a new error wrap GitCliError with is_spurious meta information.
• Update the CARGO_NET_GIT_FETCH_WITH_CLI code path to mark git fetch as
  spurious and retry on failure

How to test and review this PR?

A test project:

# ...
[dependencies]
my-dep = { git = "http://localhost:9999" }

CARGO_NET_GIT_FETCH_WITH_CLI=true cargo build

[rustbot]

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[0xPoe]

Thanks!

I guess it would be great if we could introduce a cargo test for it.

For example:

#[cargo_test(public_network_test, requires = "git")]
fn git_spurious_error_message() {
    let p = project()
        .file(
            "Cargo.toml",
            r#"
                [package]
                name = "foo"
                version = "0.1.0"
                edition = "2015"

                [dependencies]
                my-dep = { git = "http://localhost:9999" }
            "#,
        )
        .file("src/lib.rs", "")
        .build();
    p.cargo("fetch")
        .env("CARGO_NET_GIT_FETCH_WITH_CLI", "true")
        .with_status(101)
        .with_stderr_data(str![[r#"
[UPDATING] git repository `http://localhost:9999/`
fatal: unable to access 'http://localhost:9999/': Failed to connect to localhost port 9999 after 0 ms: Couldn't connect to server
[WARNING] spurious network error (3 tries remaining): process didn't exit successfully: `git fetch --no-tags --force --update-head-ok 'http://localhost:9999/' '+HEAD:refs/remotes/origin/HEAD'` ([EXIT_STATUS]: 128)
fatal: unable to access 'http://localhost:9999/': Failed to connect to localhost port 9999 after 0 ms: Couldn't connect to server
[WARNING] spurious network error (2 tries remaining): process didn't exit successfully: `git fetch --no-tags --force --update-head-ok 'http://localhost:9999/' '+HEAD:refs/remotes/origin/HEAD'` ([EXIT_STATUS]: 128)
fatal: unable to access 'http://localhost:9999/': Failed to connect to localhost port 9999 after 0 ms: Couldn't connect to server
[WARNING] spurious network error (1 try remaining): process didn't exit successfully: `git fetch --no-tags --force --update-head-ok 'http://localhost:9999/' '+HEAD:refs/remotes/origin/HEAD'` ([EXIT_STATUS]: 128)
fatal: unable to access 'http://localhost:9999/': Failed to connect to localhost port 9999 after 0 ms: Couldn't connect to server
[ERROR] failed to get `my-dep` as a dependency of package `foo v0.1.0 ([ROOT]/foo)`

Caused by:
  failed to load source for dependency `my-dep`

Caused by:
  Unable to update http://localhost:9999/

Caused by:
  failed to clone into: [ROOT]/home/.cargo/git/db/_empty-[HASH]

Caused by:
  process didn't exit successfully: `git fetch --no-tags --force --update-head-ok 'http://localhost:9999/' '+HEAD:refs/remotes/origin/HEAD'` ([EXIT_STATUS]: 128)

"#]])
        .run();
}

[BiagioFesta]

github_fastpath_error_message (test) already contains CARGO_NET_GIT_FETCH_WITH_CLI. Do you feel adding a new test or just changing the matching string?

[weihanglo]

Either works, but don't over match GitHub specific error messages

[0xPoe]

Thanks!

[0xPoe]

Thank you for working on this! I will let Weihang take another look before we merge it! Looks great for me.