Fix grammar mistake in bad Cargo.toml name error. #16090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
rustbot
added
A-filesystem
|
From the rustc errors and lints style guide
Though I do agree that the following is a run on sentence. |
weihanglo
reviewed
Oct 12, 2025
| } else if src.path().join("cargo.toml").exists() { | ||
| bail!( | ||
| "`{}` does not contain a Cargo.toml file, but found cargo.toml please try to rename it to Cargo.toml. \ | ||
| "`{}` does not contain a Cargo.toml file, but does contain cargo.toml. Please try to rename it to Cargo.toml. \ |
There was a problem hiding this comment.
Probably add a help: and in the future we migrate to annotate-snippets
Suggested change
| "`{}` does not contain a Cargo.toml file, but does contain cargo.toml. Please try to rename it to Cargo.toml. \ | |
| "`{}` does not contain a Cargo.toml file, but does contain cargo.toml\nhelp: try to rename it to Cargo.toml |
There was a problem hiding this comment.
I feel like this is more in line with the style guide:
Suggested change
| "`{}` does not contain a Cargo.toml file, but does contain cargo.toml. Please try to rename it to Cargo.toml. \ | |
| "`{}` does not contain a `Cargo.toml` file | |
| help: a `cargo.toml` exists |
| if find_project_manifest_exact(path, "cargo.toml").is_ok() { | ||
| Err(anyhow::format_err!( | ||
| "Could not find Cargo.toml in `{}`, but found cargo.toml please try to rename it to Cargo.toml", | ||
| "Could not find Cargo.toml in `{}`, but found cargo.toml. Please try to rename it to Cargo.toml", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
A small grammar mistake in the error that shows when a Cargo.toml file can not be found, but a cargo.toml can.