Skip to content

fix: Fixed nightly tests failing due to unused_variables lint #16098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2025
Merged

fix: Fixed nightly tests failing due to unused_variables lint #16098

merged 2 commits into from
Oct 13, 2025

Conversation

ranger-ross
Copy link
Member

@ranger-ross ranger-ross commented Oct 13, 2025 •
edited
Loading

What does this PR try to resolve?

Fixes nightly tests in CI. Follow up on #16082

tracked in: #16097

r? @weihanglo

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2025
weihanglo
weihanglo approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@weihanglo weihanglo enabled auto-merge October 13, 2025 14:18
@ranger-ross
Copy link
Member Author

ranger-ross commented Oct 13, 2025 •
edited
Loading

oh darn, there is another test failing in crates/rustfix :(

I could bless that one too but I find the suggestion a bit questionable

-     let mut y = true;
+     let mut _y = true;
      foo(Box::new(move || y = false) as Box<_>); //~ ERROR cannot assign to captured outer variable

@weihanglo
Copy link
Member

Looks like a false positive? This might be worth reporting back to related rustc issue/PR.

@weihanglo
Copy link
Member

We could probably ignore the test to unblock us, and track the temporary test disablement in #16097.

@ranger-ross
Copy link
Member Author

Yeah sounds reasonable 👍

auto-merge was automatically disabled October 13, 2025 14:48

Head branch was pushed to by a user without write access

@ranger-ross
Copy link
Member Author

okay I think the tests are fixed

.... But now the bump version job wants to bump the rustfix version for some reason even though the only files changed are in crates/rustfix/tests

@weihanglo
Copy link
Member

weihanglo commented Oct 13, 2025 •
edited
Loading

The bump version job is not smart enough to know your change doesn't affect production code. It basically checks git diff against the entire member directory. A patch version bump should suffice

@ranger-ross
Copy link
Member Author

The bump version job is not smart enough to know your change doesn't affect production code. It basically checks git diff against the entire member directory. A patch version bump should suffice.

Thanks, I just figured that out now.
I bumped the patch version in rustfix to 0.9.4.
Hopefully 3rd times the charm.

@weihanglo
Copy link
Member

BTW some of the publish workflows were mentioned in #13397 (comment)

It is tempted to make bump-check determining the publish state by verifying .crate tarball checksum, but this doesn't solve this because the crate tarball does change in our case

@weihanglo weihanglo mentioned this pull request Oct 13, 2025
Closed
weihanglo
weihanglo approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping unblock our CI!

@weihanglo weihanglo enabled auto-merge October 13, 2025 15:49
@weihanglo weihanglo added this pull request to the merge queue Oct 13, 2025
Merged via the queue into rust-lang:master with commit 5f26ace Oct 13, 2025
27 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2025
@ranger-ross ranger-ross deleted the fix-tests branch October 14, 2025 14:23
@Muscraft Muscraft mentioned this pull request Oct 15, 2025
Merged
bors added a commit to rust-lang/rust that referenced this pull request Oct 15, 2025
@bors
Auto merge of #147730 - Muscraft:update-cargo, r=Muscraft
3f2a592 
Update cargo

17 commits in 81c3f77a467359c8be6bc747dc93ec66a6e4ce11..367fd9f213750cd40317803dd0a5a3ce3f0c676d
2025-10-10 18:41:02 +0000 to 2025-10-15 15:01:32 +0000
- test: Don't look for a specfic ANSI color (rust-lang/cargo#16118)
- docs(guide): Clarify where to set config (rust-lang/cargo#16107)
- test(rustfix): re-enable disabled test due to unused variables (rust-lang/cargo#16114)
- Convert the "manifest has no things" warning to annotate_snippets. (rust-lang/cargo#16113)
- doc: make it clearer that `target.&lt;cfg&gt;.linker` is supported (rust-lang/cargo#16112)
- docs(guide): Cover feature-unification (rust-lang/cargo#16108)
- fix(gctx): types are unsupported not unknown (rust-lang/cargo#16109)
- fix(script): Tweak cargo script build-dir / target-dir (rust-lang/cargo#16086)
- docs(gctx): explain Value deserialization step-by-step (rust-lang/cargo#16105)
- docs(guide): Talk about removing unused features (rust-lang/cargo#16085)
- test(config): exercise unsupported TOML types (rust-lang/cargo#16100)
- docs(gctx): a bit more of how config deserialization works (rust-lang/cargo#16094)
- Refactor `Layout` into `BuildDirLayout` and `ArtifactDirLayout` (rust-lang/cargo#16092)
- Add alternative linker to the build performance guide (rust-lang/cargo#15991)
- refactor(gctx): extract error to a module (rust-lang/cargo#16091)
- fix: Fixed nightly tests failing due to unused_variables lint (rust-lang/cargo#16098)
- fix(script): Store cargo script lockfiles in build-dir (rust-lang/cargo#16087)

r? ghost
@rustbot rustbot added this to the 1.92.0 milestone Oct 15, 2025
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Oct 16, 2025
@bors
Auto merge of #147730 - Muscraft:update-cargo, r=Muscraft
0f839ef 
Update cargo

17 commits in 81c3f77a467359c8be6bc747dc93ec66a6e4ce11..367fd9f213750cd40317803dd0a5a3ce3f0c676d
2025-10-10 18:41:02 +0000 to 2025-10-15 15:01:32 +0000
- test: Don't look for a specfic ANSI color (rust-lang/cargo#16118)
- docs(guide): Clarify where to set config (rust-lang/cargo#16107)
- test(rustfix): re-enable disabled test due to unused variables (rust-lang/cargo#16114)
- Convert the "manifest has no things" warning to annotate_snippets. (rust-lang/cargo#16113)
- doc: make it clearer that `target.&lt;cfg&gt;.linker` is supported (rust-lang/cargo#16112)
- docs(guide): Cover feature-unification (rust-lang/cargo#16108)
- fix(gctx): types are unsupported not unknown (rust-lang/cargo#16109)
- fix(script): Tweak cargo script build-dir / target-dir (rust-lang/cargo#16086)
- docs(gctx): explain Value deserialization step-by-step (rust-lang/cargo#16105)
- docs(guide): Talk about removing unused features (rust-lang/cargo#16085)
- test(config): exercise unsupported TOML types (rust-lang/cargo#16100)
- docs(gctx): a bit more of how config deserialization works (rust-lang/cargo#16094)
- Refactor `Layout` into `BuildDirLayout` and `ArtifactDirLayout` (rust-lang/cargo#16092)
- Add alternative linker to the build performance guide (rust-lang/cargo#15991)
- refactor(gctx): extract error to a module (rust-lang/cargo#16091)
- fix: Fixed nightly tests failing due to unused_variables lint (rust-lang/cargo#16098)
- fix(script): Store cargo script lockfiles in build-dir (rust-lang/cargo#16087)

r? ghost
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Oct 18, 2025
@bors
Auto merge of #147730 - Muscraft:update-cargo, r=Muscraft
8b4c426 
Update cargo

17 commits in 81c3f77a467359c8be6bc747dc93ec66a6e4ce11..367fd9f213750cd40317803dd0a5a3ce3f0c676d
2025-10-10 18:41:02 +0000 to 2025-10-15 15:01:32 +0000
- test: Don't look for a specfic ANSI color (rust-lang/cargo#16118)
- docs(guide): Clarify where to set config (rust-lang/cargo#16107)
- test(rustfix): re-enable disabled test due to unused variables (rust-lang/cargo#16114)
- Convert the "manifest has no things" warning to annotate_snippets. (rust-lang/cargo#16113)
- doc: make it clearer that `target.&lt;cfg&gt;.linker` is supported (rust-lang/cargo#16112)
- docs(guide): Cover feature-unification (rust-lang/cargo#16108)
- fix(gctx): types are unsupported not unknown (rust-lang/cargo#16109)
- fix(script): Tweak cargo script build-dir / target-dir (rust-lang/cargo#16086)
- docs(gctx): explain Value deserialization step-by-step (rust-lang/cargo#16105)
- docs(guide): Talk about removing unused features (rust-lang/cargo#16085)
- test(config): exercise unsupported TOML types (rust-lang/cargo#16100)
- docs(gctx): a bit more of how config deserialization works (rust-lang/cargo#16094)
- Refactor `Layout` into `BuildDirLayout` and `ArtifactDirLayout` (rust-lang/cargo#16092)
- Add alternative linker to the build performance guide (rust-lang/cargo#15991)
- refactor(gctx): extract error to a module (rust-lang/cargo#16091)
- fix: Fixed nightly tests failing due to unused_variables lint (rust-lang/cargo#16098)
- fix(script): Store cargo script lockfiles in build-dir (rust-lang/cargo#16087)

r? ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@weihanglo weihanglo

Labels

Command-fix

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ranger-ross @weihanglo @rustbot