fix(info): resolve underscore vs hyphen mismatch in schema lookup

[dhruv-38]

What does this PR try to resolve?

This PR makes cargo info handle crate names with underscores (_) the same way as cargo add, by translating underscores to hyphens (-) and emitting a warning and also the other way around.

Currently, cargo info my_package and cargo info my-crate fails even when the actual crate name is my-package and my_crate respectively, which is surprising and inconsistent with other Cargo commands. This change aligns cargo info with
existing behavior and improves usability.

Fixes #16442

How to test and review this PR?

Run the added tests:
cargo test --test testsuite -- cargo_info::crate_name_normalization_from_hyphen_to_underscore
cargo test --test testsuite -- cargo_info::crate_name_normalization_from_underscore_to_hyphen

Manually verify behavior:
cargo info esp_println
cargo info big-s

This should succeed, show a warning about translating _ to - and also - to _, and display the crate info.

The change includes a test that captures the previous failing behavior and verifies the new expected output.

[rustbot]

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[dhruv-38]

i will add one more commit for the functionality change, before that please check this code if it is good or not?

[ranger-ross]

I think the test looks good and does what we want. Though rustfmt is failing so you'll need to fix that.
otherwise I think you should be good to start implementing the change :)

View changes since this review

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[ranger-ross]

From discussion in #general > writing test for cargo @ 💬

One question about the selection behavior (MSRV) is: If there are 2 crates foo-bar (MSRV 1.91) and foo_bar (MSRV 1.70) and I execute cargo info foo-bar from a workspace that has an MSRV lower than 1.91 which crate should be selected. For me I feel cargo info should not change the crate name if there is an exact match, even if that exact match does not satisfy the MSRV of the current workspace.

Currently Cargo will prioritize crates that match the current workspace's MSRV (ref) when selecting the package.
This is less noticable when we have an Exact query as it only affects versions.
With normalized queries its possible for Cargo have an exact match that does not satisfy the MSRV, so we could potentially select a different crate even though the exact match exists. (which feels like the wrong behavior for cargo info to me)

Not sure how others feel about this behavior but I wanted to call this out during review.

Edit: Apparently crates.io does not allow publishing crates with the same name as an existing crate with hyphens instead of underscores and vise versa. So my concern here might not be a problem in practice. Though unsure if we need to worry about 3rd party registries. I don't see this behavior specified in the Cargo registry API docs.

[ranger-ross]

These changes look good to me.

Given that @0xPoe is the one that added this command originally, I'll assign them for a Cargo team member review :)

r? @0xPoe

View changes since this review

[0xPoe]

I just renamed the PR title, as we usually only include one type in the Conventional Message.

[epage]

Thanks @dhruv-38 for implementing this and @ranger-ross for reviewing it!

View changes since this review