Fix test name completion in ZSH #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was caused by a syntax error.
--precise argument for the update command was fed test names. This commit prevents autocompletion of --precise.
Test item autocompletion didn't work because it required the name of the test to come immediately after [[test]] line. This commit should fix that.
|
r? @wycats (rust_highfive has picked a reviewer for you, use r? to override) |
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64 |
bors
added a commit
that referenced
this pull request
Jun 22, 2019
_cargo: Make function style consistent They are just white-space changes. I'm planning to bring back Zsh completion for `-p` (package) option, which was disabled in #1713. This PR is the first stepping stone towards that goal. A disadvantageous is that I am just starting to learn Zsh completion system. Guess how far can I go? r? @ehuss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1703