Pass --cap-lints=allow instead of -Awarnings #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support to Cargo to pass `--cap-lints allow` to all upstream dependencies instead of `-A warings`. This should serve the same purpose of suppressing warnings in upstream dependencies as well as preventing widespread breakage whenever a change to a lint is introduced in the compiler.
|
r? @wycats (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @brson |
| if cx.config.rustc_info().cap_lints { | ||
| rustc.arg("--cap-lints").arg("allow"); | ||
| } else { | ||
| rustc.arg("-Awarnings"); |
There was a problem hiding this comment.
It's slightly amusing that the --allow warnings flag is being passed when !allow_warnings.
|
ping r? @brson |
|
@bors r+ |
|
📌 Commit ff96fa1 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 4, 2015
This commit adds support to Cargo to pass `--cap-lints allow` to all upstream dependencies instead of `-A warings`. This should serve the same purpose of suppressing warnings in upstream dependencies as well as preventing widespread breakage whenever a change to a lint is introduced in the compiler.
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
This was referenced Aug 4, 2015
SimonSapin
added a commit
to servo/servo
that referenced
this pull request
Aug 6, 2015
Manishearth
added a commit
to Manishearth/servo
that referenced
this pull request
Aug 7, 2015
Upgrade cargo to 0.4.0-nightly (425fd85 2015-08-05) Pick up rust-lang/cargo#1830 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7049) <!-- Reviewable:end -->
Manishearth
added a commit
to Manishearth/servo
that referenced
this pull request
Aug 7, 2015
Upgrade cargo to 0.4.0-nightly (425fd85 2015-08-05) Pick up rust-lang/cargo#1830 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7049) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Aug 7, 2015
Upgrade cargo to 0.4.0-nightly (425fd85 2015-08-05) Pick up rust-lang/cargo#1830 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7049) <!-- Reviewable:end -->
SimonSapin
added a commit
to servo/servo
that referenced
this pull request
Aug 20, 2015
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Aug 20, 2015
Upgrade cargo to 0.5.0-nightly (657e363 2015-08-19) Pick up rust-lang/cargo#1830 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7049) <!-- Reviewable:end -->
jrmuizel
pushed a commit
to jrmuizel/gecko-cinnabar
that referenced
this pull request
Jun 12, 2017
…19) (from servo:cargoup); r=SimonSapin Pick up rust-lang/cargo#1830 Source-Repo: https://github.com/servo/servo Source-Revision: 5bab439ab6c58a5b78a6c2f69d6e93ad80da560f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 30, 2019
…19) (from servo:cargoup); r=SimonSapin Pick up rust-lang/cargo#1830 Source-Repo: https://github.com/servo/servo Source-Revision: 5bab439ab6c58a5b78a6c2f69d6e93ad80da560f UltraBlame original commit: 02cb3705bc4c1343e76fceea5cf968db19e89e02
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…19) (from servo:cargoup); r=SimonSapin Pick up rust-lang/cargo#1830 Source-Repo: https://github.com/servo/servo Source-Revision: 5bab439ab6c58a5b78a6c2f69d6e93ad80da560f UltraBlame original commit: 02cb3705bc4c1343e76fceea5cf968db19e89e02
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…19) (from servo:cargoup); r=SimonSapin Pick up rust-lang/cargo#1830 Source-Repo: https://github.com/servo/servo Source-Revision: 5bab439ab6c58a5b78a6c2f69d6e93ad80da560f UltraBlame original commit: 02cb3705bc4c1343e76fceea5cf968db19e89e02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support to Cargo to pass
--cap-lints allowto all upstreamdependencies instead of
-A warings. This should serve the same purpose ofsuppressing warnings in upstream dependencies as well as preventing widespread
breakage whenever a change to a lint is introduced in the compiler.