don't build/run doctests when target != host #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⌛ Testing commit fa34134 with merge 38bc8a3... |
|
💔 Test failed - cargo-win-msvc-64 |
|
Pushed a commit fixing the cross_tests test |
|
(I don't think I have r+ rights here, but worth a shot) @bors: r=alexcrichton |
|
@bors: r+ |
|
📌 Commit d37d38c has been approved by |
bors
added a commit
that referenced
this pull request
Mar 15, 2016
don't build/run doctests when target != host fixes rust-lang/rust#31907 r? @alexcrichton
|
💔 Test failed - cargo-mac-32 |
|
Pushed a commit fixing my previous fix |
|
but who fixes the fix of the fix?! @bors: r+ |
|
📌 Commit ac46a1b has been approved by |
bors
added a commit
that referenced
this pull request
Mar 15, 2016
don't build/run doctests when target != host fixes rust-lang/rust#31907 r? @alexcrichton
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
3 tasks
briansmith
added a commit
to briansmith/ring
that referenced
this pull request
Jun 6, 2016
It seems doctests are disabled when cross-compiling as of rust-lang/cargo#2485. Thus, we don't need this workaround any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes rust-lang/rust#31907
r? @alexcrichton