Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "extension-css" option #2664

Closed
wants to merge 1 commit into from
Closed

Add "extension-css" option #2664

wants to merge 1 commit into from

Conversation

GuillaumeGomez
Copy link
Member

It is the continuation of the merged extend-css into rustdoc.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomez
Copy link
Member Author

Any news?

@alexcrichton
Copy link
Member

We generally don't add a configuration option for all rustc/rustdoc options, especially unstable ones. I think it's premature to add an entire Cargo.toml configuration option for this, and the best way to enable this functionality would probably be through RUSTDOCFLAGS similarly to how RUSTFLAGS are handled.

@GuillaumeGomez
Copy link
Member Author

We can keep it open until it's in release version. However, wouldn't it shadow the feature to force people to use cargo flags instead of an option into Cargo.toml?

@alexcrichton
Copy link
Member

This will likely require something along the lines of an RFC for dealing with rustdoc options in general in Cargo. There are many more options that want to be specified beyond just this one (e.g. #331).

@alexcrichton
Copy link
Member

oops

@alexcrichton
Copy link
Member

Ah I've since created a PR for RUSTDOCFLAGS at #2794 so I'm going to close this in favor of that, thanks for the PR though!

@GuillaumeGomez
Copy link
Member Author

Great! Your solution is indeed better. Thanks @alexcrichton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants