Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report status to stderr instead of stdout #2693

Merged
merged 26 commits into from
May 20, 2016
Merged

report status to stderr instead of stdout #2693

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
f88b581
report status to stderr instead of stdout
matklad May 14, 2016
c015744
fix test_cargo_build_auth
matklad May 14, 2016
7923023
fix test_cargo_build_lib
matklad May 14, 2016
c9d6130
fix test_cargo_clean
matklad May 14, 2016
1a2257b
fix a bunch of tests with regexp
matklad May 14, 2016
2904e36
fix some more tests with regexp
matklad May 14, 2016
e7839b1
fix some tests with IntelliJ-Rust automated refactoring
matklad May 15, 2016
232858f
fix test_cargo_test
matklad May 15, 2016
415d962
fix more tests with regex
matklad May 15, 2016
9f408ee
fix more test with insane regexes
matklad May 15, 2016
4b624c9
fix more tests
matklad May 15, 2016
db7d59e
fix exit_code tests
matklad May 15, 2016
97f91a1
fix test_cargo_install
matklad May 15, 2016
5751066
more regexp fixes
matklad May 18, 2016
ca29668
fix more tests with auto refactoring
matklad May 19, 2016
e78956d
more auto refactoring fixes
matklad May 19, 2016
ba1c094
fix test_cargo_registry
matklad May 20, 2016
eeebadf
fix test_cargo_package
matklad May 20, 2016
40fd7a7
one more regexp
matklad May 20, 2016
b5633e6
fix test_cargo_overrides
matklad May 20, 2016
eb9a118
fix test_cargo_bench
matklad May 20, 2016
c57c3ae
fix some cargo_compile tests
matklad May 20, 2016
d0a14eb
fix test_compile_git_deps
matklad May 20, 2016
4057f43
fix test_cargo_freshness
matklad May 20, 2016
1c991f8
fix test_cargo_publish
matklad May 20, 2016
f2eb995
fix cargo_compile_path_deps
matklad May 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_cargo_compile_path_deps.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ test!(nested_deps_recompile {

name = "bar"
"#)
.file("src/bar/src/bar.rs", "pub fn gimme() {}");
.file("src/bar/src/bar.rs", "pub fn gimme() -> i32 { 92 }");
let bar = p.url();

assert_that(p.cargo_process("build"),
Expand Down Expand Up @@ -722,7 +722,7 @@ test!(dev_deps_no_rebuild_lib {
"#)
.file("src/lib.rs", r#"
#[cfg(test)] extern crate bar;
#[cfg(not(test))] fn foo() { env!("FOO"); }
#[cfg(not(test))] pub fn foo() { env!("FOO"); }
Copy link
Member Author

@matklad matklad May 20, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcrichton this tests looks a bit strange. Looks like it should set and read an environmental variable, but it actually is never asserted (and "unused function foo" is printed during the compilation).

Perhaps the test doesn't test what it is supposed to?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the env! macro fails compilation if the env var isn't defined

"#)
.file("bar/Cargo.toml", r#"
[package]
Expand Down