Ban keywords from crate names #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wycats (rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks! Could you add a comment with a link to that page as well? Other than that r=me |
sbeckeriv
force-pushed
the
banned-list-2699
branch
from
3f4021a
to
466c74a
Compare
Dearest Reviewer, This pull request extends the banned list of project names to include all of the current keywords for rust. I got the list of keywords from https://doc.rust-lang.org/grammar.html#keywords . This closes rust-lang#2699 . The original ticket said warn but I figured how test is handled is most likely how all banned names should be handled. Oddly enough a few keywords have made their way to the crates.io. fn and proc are both examples I found spot checking keywords. I do not there is any action to take on those crates. Thanks Becker
|
Updated. Thanks! |
bors
added a commit
that referenced
this pull request
May 17, 2016
Ban keywords from crate names Dearest Reviewer, This pull request extends the banned list of project names to include all of the current keywords for rust. I got the list of keywords from https://doc.rust-lang.org/grammar.html#keywords . This closes #2699 . The original ticket said warn but I figured how test is handled is most likely how all banned names should be handled. Oddly enough a few keywords have made their way to the crates.io. fn and proc are both examples I found spot checking keywords. I do not there is any action to take on those crates. Thanks Becker
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dearest Reviewer,
This pull request extends the banned list of project names to include
all of the current keywords for rust. I got the list of keywords from
https://doc.rust-lang.org/grammar.html#keywords . This
closes #2699 . The original ticket said warn but I figured how test is
handled is most likely how all banned names should be handled.
Oddly enough a few keywords have made their way to the crates.io. fn and
proc are both examples I found spot checking keywords. I do not there is
any action to take on those crates.
Thanks
Becker