Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cdylib crate types #2741

Merged
merged 1 commit into from
Jun 12, 2016
Merged

Conversation

alexcrichton
Copy link
Member

And while we're at it this also extends support for all future crate types
assuming that they aren't linkable by default.

@rust-highfive
Copy link

r? @wycats

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Contributor

bors commented May 26, 2016

☔ The latest upstream changes (presumably #2743) made this pull request unmergeable. Please resolve the merge conflicts.

let suffix = match parts.next() {
Some(part) => part,
None => bail!("output of --print=file-names has change in \
the compiler, cannot parse"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "has change"

@brson
Copy link
Contributor

brson commented Jun 11, 2016

r=me

And while we're at it this also extends support for all future crate types
assuming that they aren't linkable by default.
@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Jun 12, 2016

📌 Commit 3f7b09c has been approved by brson

@bors
Copy link
Contributor

bors commented Jun 12, 2016

⌛ Testing commit 3f7b09c with merge b742d5c...

bors added a commit that referenced this pull request Jun 12, 2016
Add support for cdylib crate types

And while we're at it this also extends support for all future crate types
assuming that they aren't linkable by default.
@bors
Copy link
Contributor

bors commented Jun 12, 2016

@bors bors merged commit 3f7b09c into rust-lang:master Jun 12, 2016
@alexcrichton alexcrichton deleted the cdylib branch June 14, 2016 14:34
@SSheldon
Copy link

Will this commit be included in whatever version of cargo is shipped with rust 1.10?

It's currently not in the 1.10 beta (that's using cargo 0.12.0-nightly (26cb07b 2016-06-07)), which is a bummer because cdylib support is in 1.10 :)

@alexcrichton
Copy link
Member Author

Unfortunately, no, this didn't make that train

@SSheldon
Copy link

Any chance of a backport? I wouldn't want to rush in something if it's not ready, but it'll be a bummer to see cdylib in the release notes for 1.10 with a disclaimer that it doesn't work with cargo, only when using rustc directly.

@alexcrichton
Copy link
Member Author

Unfortunately we don't have a backport process in place for Cargo so we can't do that just yet, but it'll certainly be in 1.11!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants