Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search dylib path from cargo before system #2891

Merged
merged 1 commit into from
Jul 19, 2016
Merged

Search dylib path from cargo before system #2891

merged 1 commit into from
Jul 19, 2016

Conversation

upsuper
Copy link
Contributor

@upsuper upsuper commented Jul 18, 2016

Cargo should have more knowledge about what it is looking for, and thus its paths should be more correct compared to system's. When there are conflicts, the search paths provided by the build system should take priority.

Cargo should have more knowledge about what it is looking for, and thus
its paths should be more correct compared to system's. When there are
conflicts, the search paths provided by the build system should take
priority.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+ 8be27b5

Thanks!

@bors
Copy link
Collaborator

bors commented Jul 18, 2016

⌛ Testing commit 8be27b5 with merge b45997c...

bors added a commit that referenced this pull request Jul 18, 2016
Search dylib path from cargo before system

Cargo should have more knowledge about what it is looking for, and thus its paths should be more correct compared to system's. When there are conflicts, the search paths provided by the build system should take priority.
@bors
Copy link
Collaborator

bors commented Jul 19, 2016

☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: alexcrichton
Pushing b45997c to master...

@bors bors merged commit 8be27b5 into rust-lang:master Jul 19, 2016
@upsuper upsuper deleted the fix-search-path branch July 19, 2016 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants