Fix depending on git repos with workspaces #2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson |
|
@alexcrichton: no appropriate reviewer found, use r? to override |
|
@bors r+ Wonder what rust-highfive is confused about. |
|
📌 Commit 1d6b6f6 has been approved by |
|
⌛ Testing commit 1d6b6f6 with merge 6292654... |
|
💔 Test failed - cargo-mac-64 |
When we're recursively walking over a git repository we can safely ignore any workspace Cargo.toml files we find instead of generating an error.
alexcrichton
force-pushed
the
virtual-in-git
branch
from
1d6b6f6 to
9243f06
Compare
|
@bors: r=brson |
|
📌 Commit 9243f06 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 1, 2016
Fix depending on git repos with workspaces When we're recursively walking over a git repository we can safely ignore any workspace Cargo.toml files we find instead of generating an error.
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're recursively walking over a git repository we can safely ignore any
workspace Cargo.toml files we find instead of generating an error.