Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove command prototype #3193

Merged
merged 1 commit into from
Oct 12, 2016
Merged

Remove command prototype #3193

merged 1 commit into from
Oct 12, 2016

Conversation

matklad
Copy link
Member

@matklad matklad commented Oct 12, 2016

A followup of #3177 . I am not sure, but perhaps we can remove/refactor CommandType as well: for each command variant, Compilation as a public dedicated method, but it also has a generic one (process) (haha: https://github.com/rust-lang/cargo/pull/1107/files#r22429844).

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Oct 12, 2016

📌 Commit 5aae6f0 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Oct 12, 2016

⌛ Testing commit 5aae6f0 with merge 4d61a61...

@bors
Copy link
Contributor

bors commented Oct 12, 2016

💔 Test failed - cargo-win-gnu-64

@alexcrichton
Copy link
Member

@bors: retry

On Wed, Oct 12, 2016 at 7:23 AM, bors notifications@github.com wrote:

💔 Test failed - cargo-win-gnu-64
https://buildbot.rust-lang.org/builders/cargo-win-gnu-64/builds/745


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3193 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95L13yF52TJMOsUYh60FNi8mDVJjGks5qzO1RgaJpZM4KUqr0
.

@bors
Copy link
Contributor

bors commented Oct 12, 2016

⌛ Testing commit 5aae6f0 with merge ee3acca...

bors added a commit that referenced this pull request Oct 12, 2016
Remove command prototype

A followup of #3177 . I am not sure, but perhaps we can remove/refactor `CommandType` as well: for each command variant, `Compilation` as a public dedicated method, but it also has a generic one (`process`) (haha: https://github.com/rust-lang/cargo/pull/1107/files#r22429844).
@bors
Copy link
Contributor

bors commented Oct 12, 2016

☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: alexcrichton
Pushing ee3acca to master...

@bors bors merged commit 5aae6f0 into rust-lang:master Oct 12, 2016
@matklad matklad deleted the kill-command-proto branch December 14, 2016 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants