-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove command prototype #3193
Remove command prototype #3193
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ Thanks! |
📌 Commit 5aae6f0 has been approved by |
⌛ Testing commit 5aae6f0 with merge 4d61a61... |
💔 Test failed - cargo-win-gnu-64 |
@bors: retry On Wed, Oct 12, 2016 at 7:23 AM, bors notifications@github.com wrote:
|
Remove command prototype A followup of #3177 . I am not sure, but perhaps we can remove/refactor `CommandType` as well: for each command variant, `Compilation` as a public dedicated method, but it also has a generic one (`process`) (haha: https://github.com/rust-lang/cargo/pull/1107/files#r22429844).
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
A followup of #3177 . I am not sure, but perhaps we can remove/refactor
CommandType
as well: for each command variant,Compilation
as a public dedicated method, but it also has a generic one (process
) (haha: https://github.com/rust-lang/cargo/pull/1107/files#r22429844).