Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose rustc cfg values to build scripts #3243

Merged
merged 1 commit into from
Nov 3, 2016

Conversation

alexcrichton
Copy link
Member

This commit is Cargo's portion of the implementation of RFC 1721 where it will
expose values printed by rustc --print cfg to build scripts.

This will in turn be used to communicate features like -C target-feature=+crt-static which can be used to compile objects for statically
linking against the msvcrt on MSVC.

@rust-highfive
Copy link

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

This commit is Cargo's portion of the implementation of [RFC 1721] where it will
expose values printed by `rustc --print cfg` to build scripts.

[RFC 1721]: https://github.com/rust-lang/rfcs/blob/master/text/1721-crt-static.md

This will in turn be used to communicate features like `-C
target-feature=+crt-static` which can be used to compile objects for statically
linking against the msvcrt on MSVC.
@brson brson added the relnotes Release-note worthy label Nov 3, 2016
@brson
Copy link
Contributor

brson commented Nov 3, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 3, 2016

📌 Commit 23587ee has been approved by brson

bors added a commit that referenced this pull request Nov 3, 2016
Expose rustc cfg values to build scripts

This commit is Cargo's portion of the implementation of [RFC 1721] where it will
expose values printed by `rustc --print cfg` to build scripts.

[RFC 1721]: https://github.com/rust-lang/rfcs/blob/master/text/1721-crt-static.md

This will in turn be used to communicate features like `-C
target-feature=+crt-static` which can be used to compile objects for statically
linking against the msvcrt on MSVC.
@bors
Copy link
Collaborator

bors commented Nov 3, 2016

⌛ Testing commit 23587ee with merge 7823422...

@bors
Copy link
Collaborator

bors commented Nov 3, 2016

☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: brson
Pushing 7823422 to master...

@bors bors merged commit 23587ee into rust-lang:master Nov 3, 2016
@alexcrichton alexcrichton deleted the target-feature branch November 3, 2016 17:49
@ehuss ehuss added this to the 1.14.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Release-note worthy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants