Improve TOML decoding error messages #3794
Merged
+194
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
matklad
reviewed
Mar 8, 2017
src/cargo/util/toml.rs
Outdated
| { | ||
| Ok(PathValue::String(String::deserialize(deserializer)?)) | ||
| } | ||
| } |
There was a problem hiding this comment.
If we are writing custom deserialization anyway, maybe we can remove String variant from the enum?
Unfortunately while `#[serde(untagged)]` is precisely what we want in terms of semantics it leaves a little to be desired in terms of error messages. This commit updates to remove the usage of that attribute in favor of implementing `Deserialize` directly, which is quite simple in these few cases. Closes rust-lang#3790
alexcrichton
force-pushed
the
better-errors
branch
from
e5561d5
to
cb53e1b
Compare
|
@bors: r+ |
|
📌 Commit cb53e1b has been approved by |
bors
added a commit
that referenced
this pull request
Mar 8, 2017
Improve TOML decoding error messages Unfortunately while `#[serde(untagged)]` is precisely what we want in terms of semantics it leaves a little to be desired in terms of error messages. This commit updates to remove the usage of that attribute in favor of implementing `Deserialize` directly, which is quite simple in these few cases. Closes #3790
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately while
#[serde(untagged)]is precisely what we want in terms ofsemantics it leaves a little to be desired in terms of error messages. This
commit updates to remove the usage of that attribute in favor of implementing
Deserializedirectly, which is quite simple in these few cases.Closes #3790