Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation on overrides #3955

Merged
merged 1 commit into from
Apr 26, 2017

Conversation

RReverser
Copy link
Contributor

  • target.linker does not seem to be supported anymore, only target.$triple.linker works, so merged these sections.
  • Added note about supported target.$triple.ar

 - target.linker does not seem to be supported anymore, only target.$triple.linker works, so merged these sections.
 - Added note about supported target.$triple.ar
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Collaborator

bors commented Apr 26, 2017

📌 Commit 841fd82 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Apr 26, 2017

⌛ Testing commit 841fd82 with merge 80e653b...

bors added a commit that referenced this pull request Apr 26, 2017
Update documentation on overrides

 - `target.linker` does not seem to be supported anymore, only `target.$triple.linker` works, so merged these sections.
 - Added note about supported `target.$triple.ar`
@bors
Copy link
Collaborator

bors commented Apr 26, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 80e653b to master...

@bors bors merged commit 841fd82 into rust-lang:master Apr 26, 2017
@ehuss ehuss added this to the 1.19.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants