Bring test of nightly in line with tests #4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
|
📌 Commit e0e4a1d has been approved by |
|
It looks like homu isn't processing approved PRs for cargo or rustup-rs. Do you know why that is @Mark-Simulacrum? |
|
@bors: retry |
|
@bors: r+ |
|
💡 This pull request was already approved, no need to approve it again. |
|
📌 Commit e0e4a1d has been approved by |
alexcrichton
force-pushed
the
better-incremental-nightly-test
branch
from
e0e4a1d
to
213a2bf
Compare
|
@bors: r+ |
|
📌 Commit 213a2bf has been approved by |
|
@bors: retry |
|
@alexcrichton it doesn't look like the issue is the approval, but rather that homu isn't taking jobs off of the queue. Jobs in the |
bors
added a commit
that referenced
this pull request
May 9, 2017
…richton Bring test of nightly in line with tests #4000 passes `-Zincremental` to `rustc` only on nightly, but uses a different mechanism for detecting nightly than [cargotest does](https://github.com/rust-lang/cargo/blob/9bf9bddd9297cfb5098be6146d85be551c6d4eff/tests/cargotest/lib.rs#L37). This PR brings the two in line, which should hopefully fix the build failure observed in rust-lang/rust#41830 (comment).
jonhoo
added a commit
to jonhoo/rust
that referenced
this pull request
May 9, 2017
Also relies on rust-lang/cargo#4010
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4000 passes
-Zincrementaltorustconly on nightly, but uses a different mechanism for detecting nightly than cargotest does. This PR brings the two in line, which should hopefully fix the build failure observed in rust-lang/rust#41830 (comment).