Only compile user-modifiable projects incrementally. #4065
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ |
|
📌 Commit 9e824c3 has been approved by |
…lexcrichton Only compile user-modifiable projects incrementally. Fixes #3972. Thanks for pointing me to the correct implementation, Alex! r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
… which includes rust-lang/cargo#4065 Compile time from `mach clean` on 4 cores / 8 thread improved by 4%.
… which includes rust-lang/cargo#4065 Compile time from `mach clean` on 4 cores / 8 threads with incremental compilation improved by 4%.
Update to cargo 0.20.0-nightly (2233f51 2017-05-17) … which includes rust-lang/cargo#4065 Compile time from `mach clean` on 4 cores / 8 thread with incremental compilation improved by 4%. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16932) <!-- Reviewable:end -->
|
Will it use incremental compilation for dependencies defined with path? path = ../lib |
|
Yes, I think so. |
Fixes #3972. Thanks for pointing me to the correct implementation, Alex!
r? @alexcrichton