Issue 4135: include = [...] should override git file list

[pnkfelix]

Fix #4135: if theres include = [...], then do not prepopulate file list via git.

[rust-highfive]

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

[alexcrichton]

Looks good to me! I think though there's a test failure on AppVeyor? It can probably be fixed with usage of [/] instead of a literal / (as it's \ on Windows)

[pnkfelix]

It can probably be fixed with usage of [/] instead of a literal / (as it's \ on Windows)

Ah I was wondering what the [/] was for, that makes sense. Will do.

[sfackler]

Will this also cause .gitignore-based exclusions to be disabled?

EDIT: ah, looks like it will.

[pnkfelix]

@sfackler yeah it will. Or rather, this will cause the code to actually conform to what is documented here, namely:

The options are mutually exclusive: setting include will override an exclude. Note that include must be an exhaustive list of files as otherwise necessary source files may not be included.

However, as I noted on the issue, I think we should plan in the future to adopt a different semantics, where include is purely additive. (I.e. exclude will operate as a blacklist filter atop the git index, and include be be a whitelist filter atop the file system.)

[pnkfelix]

@bors r=alexcrichton

[bors]

@pnkfelix: 🔑 Insufficient privileges: Not in reviewers

[Mark-Simulacrum]

@bors r=alexcrichton

You can make a PR to https://github.com/rust-lang/rust-central-station to get r+ rights.

[bors]

📌 Commit 749ec6e has been approved by alexcrichton

[bors]

⌛ Testing commit 749ec6e with merge d23510c...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing d23510c to master...