-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace cargo publish --host
with cargo publish --index
#4209
Conversation
…rts --host however deprecation warning is issued
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors: r+ Looks great to me, thanks! |
📌 Commit 78e64de has been approved by |
⌛ Testing commit 78e64de with merge 39ebce40f79dac824f5d51c2641dccdba20b09aa... |
💔 Test failed - status-travis |
@bors: retry |
Add error-chain errors. Fixes rust-lang#4209 Convert CargoResult, CargoError into an implementation provided by error-chain. The previous is_human machinery is mostly removed; now errors are displayed unless of the Internal kind, verbose mode will print all errors.
⌛ Testing commit 78e64de with merge 1f280eb0390551e4cb56181054fa747679879c6a... |
💔 Test failed - status-appveyor |
@bors: retry |
☀️ Test successful - status-appveyor, status-travis |
Update Cargo Haven't run extensive tests locally (not really sure what to test) but this primarily pulls in minor changes: rust-lang/cargo#4215, rust-lang/cargo#4209, and rust-lang/cargo#4218. The last one fixes the flaky cargo test by ignoring it, which should unblock #42745 -- that's beta nominated. r? @alexcrichton
1086: Update contribution guidelines to use --index r=carols10cents Introduced in rust-lang/cargo#4209
This change makes the command consistent with other versions with the same flag.
cargo publish --host
is still supported, currently marked as deprecated, or for reuse as mentioned in issue #4208.Fixes #3797