Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the cargo_bench_failing_test tolerate col info #4244

Merged
merged 1 commit into from
Jul 2, 2017

Conversation

est31
Copy link
Member

@est31 est31 commented Jul 2, 2017

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@matklad
Copy link
Member

matklad commented Jul 2, 2017

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jul 2, 2017

📌 Commit 6f34f86 has been approved by matklad

@bors
Copy link
Contributor

bors commented Jul 2, 2017

⌛ Testing commit 6f34f86 with merge 5bf71ab...

bors added a commit that referenced this pull request Jul 2, 2017
Let the cargo_bench_failing_test tolerate col info

Needed by rust-lang/rust#42938
@bors
Copy link
Contributor

bors commented Jul 2, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 5bf71ab to master...

@bors bors merged commit 6f34f86 into rust-lang:master Jul 2, 2017
est31 added a commit to est31/rust that referenced this pull request Jul 2, 2017
@ehuss ehuss added this to the 1.20.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants