Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Requirements struct to clarify code #4683

Merged
merged 8 commits into from
Oct 31, 2017
Merged

Introduce Requirements struct to clarify code #4683

merged 8 commits into from
Oct 31, 2017

Commits on Oct 30, 2017

  1. Move resolution requirement state into a separate struct

    @djc
    djc committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    e87f151 View commit details
    Browse the repository at this point in the history

  2. Extract method for requiring crate features

    @djc
    djc committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    e1303ec View commit details
    Browse the repository at this point in the history

  3. Extract function to record if a feature was seen before

    @djc
    djc committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    63281c7 View commit details
    Browse the repository at this point in the history

  4. Extract method for recording a requested dependency

    @djc
    djc committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    c3c387d View commit details
    Browse the repository at this point in the history

  5. Extract method for handling feature requirements

    @djc
    djc committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    1b01e36 View commit details
    Browse the repository at this point in the history

  6. Move shared logic into separated methods

    @djc
    djc committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    8278876 View commit details
    Browse the repository at this point in the history

  7. Move logic for walking over dependent features around

    @djc
    djc committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    8890568 View commit details
    Browse the repository at this point in the history

  8. Use specific methods to add requirements

    @djc
    djc committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    abf4122 View commit details
    Browse the repository at this point in the history