Ensure [target] rustflags are deterministically passed
#4950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage of `HashMap` in the `Config` tables introduced some nondeterminism, so reverse that with a sort right before we pass it down to rustc. One day we'll probably want to sort by the position where these keys were defined, but for now a blanket sort should do the trick. Closes rust-lang#4935
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ 👍 |
|
📌 Commit c9803a4 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 16, 2018
Ensure `[target]` rustflags are deterministically passed The usage of `HashMap` in the `Config` tables introduced some nondeterminism, so reverse that with a sort right before we pass it down to rustc. One day we'll probably want to sort by the position where these keys were defined, but for now a blanket sort should do the trick. Closes #4935
|
💔 Test failed - status-travis |
|
@bors: retry
…On Tue, Jan 16, 2018 at 7:43 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/cargo/builds/329664890?utm_source=github_status&utm_medium=notification>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4950 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95MMzrUFANInMSmkBUirTTWin1Zsqks5tLVBAgaJpZM4RgS8s>
.
|
|
⌛ Testing commit c9803a4 with merge 1fbb5ca633dc71faa958860934ccafdd683b4c0a... |
|
💔 Test failed - status-appveyor |
|
@bors: retry
…On Wed, Jan 17, 2018 at 3:28 AM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang-libs/cargo/build/1.0.3442>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4950 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95AyaCv9MQ882NVgEBudw6tpzeodzks5tLb0lgaJpZM4RgS8s>
.
|
bors
added a commit
that referenced
this pull request
Jan 17, 2018
Ensure `[target]` rustflags are deterministically passed The usage of `HashMap` in the `Config` tables introduced some nondeterminism, so reverse that with a sort right before we pass it down to rustc. One day we'll probably want to sort by the position where these keys were defined, but for now a blanket sort should do the trick. Closes #4935
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of
HashMapin theConfigtables introduced some nondeterminism, soreverse that with a sort right before we pass it down to rustc. One day we'll
probably want to sort by the position where these keys were defined, but for now
a blanket sort should do the trick.
Closes #4935