Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backtrack if can not activate #5000

Merged
merged 5 commits into from
Mar 1, 2018
Merged

backtrack if can not activate #5000

merged 5 commits into from
Mar 1, 2018

Commits on Mar 1, 2018

  1. add a test for cargo/issues/4347

    @Eh2406
    Eh2406 committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    8348469 View commit details
    Browse the repository at this point in the history

  2. WIP: make it recurs if activation fails

    @Eh2406
    Eh2406 committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    3300728 View commit details
    Browse the repository at this point in the history

  3. fix the todo's 

    needs a test where we have an activation_error the then try activate something that dose not work and backtrack to where we had the activation_error then:
- Hit fast backtracking that go past the crate with the missing features
- Or give a bad error message that does not mention the activation_error.
The test will pass, but there is code that is not yet justified by tests
    @Eh2406
    Eh2406 committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    5d4402c View commit details
    Browse the repository at this point in the history

  4. One more todo to fix

    @Eh2406
    Eh2406 committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    6218584 View commit details
    Browse the repository at this point in the history

  5. fix cause and the error messages

    @Eh2406
    Eh2406 committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    2cbd1dd View commit details
    Browse the repository at this point in the history