-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Implement features
#509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement features
#509
Conversation
|
Oops, wrong title! |
221be42 to
cf3221c
Compare
src/doc/source/manifest.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cargo or feature?
|
Is the definition of a dependency-less feature allowed? For example, rust-openssl has support for SSLv2 hidden behind a cfg flag: https://github.com/sfackler/rust-openssl/blob/4a823242abd136417939a49ebb121533381c01ca/src/ssl/mod.rs#L51. That kind of use case might be worth mentioning in the docs. |
d7b346c to
e52624f
Compare
|
Aha, thanks for reminding me @sfackler! That caught a few bugs here and there, and I've put an explicit mention in the documentation now as well. Some interesting changes to resolve:
|
e52624f to
3d9b7af
Compare
|
@alexcrichton Any update on this? |
|
I need to work on getting this rebased past the implementation of the registry, which will require some finesse that is not currently implemented. |
3d9b7af to
2b86666
Compare
|
Rebased, r? @wycats |
2b86666 to
71c79ac
Compare
|
r+ I think this will need a bit of cleanup at some point, but I'm ok with it as is. |
71c79ac to
bff1367
Compare
This feature was outlined in rust-lang#385 [1], and documentation has been included as part of this commit. [1]: rust-lang#385 (comment)
bff1367 to
2b46d03
Compare
This feature was outlined in #385 [1], and documentation has been included as part of this commit. [1]: #385 (comment) Closes #385
This feature was outlined in #385 1, and documentation has been included as
part of this commit.
Closes #385