Fix regression when passing arguments to subcommands #5209
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@rust-highfive: 🔑 Insufficient privileges: Not in reviewers |
|
@rust-highfive: 🔑 Insufficient privileges: not in try users |
|
@bors: r+ |
|
📌 Commit 84e08c2 has been approved by |
|
War of robots against robots? |
|
@bors: p=1 |
|
🔒 Merge conflict |
|
☔ The latest upstream changes (presumably #5207) made this pull request unmergeable. Please resolve the merge conflicts. |
matklad
force-pushed
the
no-way-we-havent-had-a-test-for-this
branch
from
84e08c2 to
0928135
Compare
|
@bors: r=alexcrichton |
|
📌 Commit 0928135 has been approved by |
|
⌛ Testing commit 0928135588a4d8fb9f92d023459ce44f2b0f2e01 with merge 175bca5d7a090e9adaa368fd04ecf85368fa147c... |
|
💔 Test failed - status-appveyor |
matklad
force-pushed
the
no-way-we-havent-had-a-test-for-this
branch
from
0928135 to
984c22e
Compare
matklad
force-pushed
the
no-way-we-havent-had-a-test-for-this
branch
from
984c22e to
deb1c1e
Compare
|
@bors: r=alexcrichton |
|
📌 Commit deb1c1e has been approved by |
…=alexcrichton Fix regression when passing arguments to subcommands closes #5208 `.args(&args[1..])` was copied directly from the docopt implementation, but there, `args[0]` was the path to `cargo` and not the name of subcommand, ie, `args` were *original* arguments for Cargo as a whole.
|
☀️ Test successful - status-appveyor, status-travis |
closes #5208
.args(&args[1..])was copied directly from the docopt implementation, but there,args[0]was the path tocargoand not the name of subcommand, ie,argswere original arguments for Cargo as a whole.