Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for absolute target.json paths #5228

Merged
merged 2 commits into from
Mar 26, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/cargo/ops/cargo_compile.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@

use std::collections::{HashMap, HashSet};
use std::default::Default;
use std::path::PathBuf;
use std::path::{Path, PathBuf};
use std::sync::Arc;

use core::{Package, Source, Target};
use core::{PackageId, PackageIdSpec, Profile, Profiles, TargetKind, Workspace};
use core::resolver::{Method, Resolve};
use ops::{self, BuildOutput, DefaultExecutor, Executor};
use util::config::Config;
use util::{profile, CargoResult};
use util::{profile, CargoResult, CargoResultExt};

/// Contains information about how a package should be compiled.
#[derive(Debug)]
Expand Down Expand Up @@ -235,7 +235,17 @@ pub fn compile_ws<'a>(
ref target_rustc_args,
} = *options;

let target = target.clone();
let target = match target {
&Some(ref target) if target.ends_with(".json") => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this clause required here? Ideally there'd only be one location where we'd deal with json targets and currently it's split across two locations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure which other location you mean. The Layout::new implementation?

The motivation for putting it here is that we canonicalize the path that is passed to rustc, to avoid the issue that the path becomes invalid due to the cwd changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sure I didn't look too too closely before, I was mostly just thinking that we should have one location where we recognize .json targets instead of two, but the most recent version only has one so that sounds good to me!

let path = Path::new(target)
.canonicalize()
.chain_err(|| format_err!("Target path {:?} is not a valid file", target))?;
Some(path.into_os_string()
.into_string()
.map_err(|_| format_err!("Target path is not valid unicode"))?)
}
other => other.clone(),
};

if jobs == Some(0) {
bail!("jobs must be at least 1")
Expand Down
170 changes: 170 additions & 0 deletions tests/testsuite/custom_target.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,170 @@
use cargotest::is_nightly;
use cargotest::support::{execs, project};
use hamcrest::assert_that;

#[test]
fn custom_target_minimal() {
if !is_nightly() {
return;
}
let p = project("foo")
.file(
"Cargo.toml",
r#"
[package]

name = "foo"
version = "0.0.1"
authors = ["author@example.com"]
"#,
)
.file(
"src/lib.rs",
r#"
#![feature(no_core)]
#![feature(lang_items)]
#![no_core]

pub fn foo() -> u32 {
42
}

#[lang = "sized"]
pub trait Sized {
// Empty.
}
#[lang = "copy"]
pub trait Copy {
// Empty.
}
"#,
)
.file(
"custom-target.json",
r#"
{
"llvm-target": "x86_64-unknown-none-gnu",
"data-layout": "e-m:e-i64:64-f80:128-n8:16:32:64-S128",
"arch": "x86_64",
"target-endian": "little",
"target-pointer-width": "64",
"target-c-int-width": "32",
"os": "none",
"linker-flavor": "ld.lld"
}
"#,
)
.build();

assert_that(
p.cargo("build")
.arg("--lib")
.arg("--target")
.arg("custom-target.json")
.arg("-v"),
execs().with_status(0),
);
assert_that(
p.cargo("build")
.arg("--lib")
.arg("--target")
.arg("src/../custom-target.json")
.arg("-v"),
execs().with_status(0),
);
}

#[test]
fn custom_target_dependency() {
if !is_nightly() {
return;
}
let p = project("foo")
.file(
"Cargo.toml",
r#"
[package]

name = "foo"
version = "0.0.1"
authors = ["author@example.com"]

[dependencies]
bar = { path = "bar" }
"#,
)
.file(
"src/lib.rs",
r#"
#![feature(no_core)]
#![feature(lang_items)]
#![feature(optin_builtin_traits)]
#![no_core]

extern crate bar;

pub fn foo() -> u32 {
bar::bar()
}

#[lang = "freeze"]
unsafe auto trait Freeze {}
"#,
)
.file(
"bar/Cargo.toml",
r#"
[package]

name = "bar"
version = "0.0.1"
authors = ["author@example.com"]
"#,
)
.file(
"bar/src/lib.rs",
r#"
#![feature(no_core)]
#![feature(lang_items)]
#![no_core]

pub fn bar() -> u32 {
42
}

#[lang = "sized"]
pub trait Sized {
// Empty.
}
#[lang = "copy"]
pub trait Copy {
// Empty.
}
"#,
)
.file(
"custom-target.json",
r#"
{
"llvm-target": "x86_64-unknown-none-gnu",
"data-layout": "e-m:e-i64:64-f80:128-n8:16:32:64-S128",
"arch": "x86_64",
"target-endian": "little",
"target-pointer-width": "64",
"target-c-int-width": "32",
"os": "none",
"linker-flavor": "ld.lld"
}
"#,
)
.build();

assert_that(
p.cargo("build")
.arg("--lib")
.arg("--target")
.arg("custom-target.json")
.arg("-v"),
execs().with_status(0),
);
}
1 change: 1 addition & 0 deletions tests/testsuite/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ mod config;
mod corrupt_git;
mod cross_compile;
mod cross_publish;
mod custom_target;
mod death;
mod dep_info;
mod directory;
Expand Down