tweak error message #5250
Merged
tweak error message #5250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Mar 27, 2018
| unit.pkg, | ||
| self.target_triple() |
There was a problem hiding this comment.
Let's be extra nice here and do something like
bail!("crate type{}", if unsupported.len() == 1 "" else "s")
?
|
@bors r+ |
|
📌 Commit 29c0169 has been approved by |
rleungx
force-pushed
the
tweak-error-message
branch
from
29c0169
to
967f094
Compare
|
@matklad It seems that |
|
@bors r+ |
|
📌 Commit 967f094 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 27, 2018
tweak error message Closes #5238.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5238.