-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address autobins warning. #5473
Conversation
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
Awesome thanks! Was about to send a PR for this too :) Could this actually shuffle the files around to match Cargo's conventions instead of setting |
To elaborate, I think we want
|
Hm, perhaps we then should hold off issuing the warning until we have a stable Cargo which supports That way, projects, which use both nightly and stable, could fix the warning without much of a hassle. On the other hand, the fix of "reshuffle directory structure so that conventions just work" seems to be better anyway. |
@bors r+ Thanks! |
📌 Commit 4224463 has been approved by |
I was mistaken in my previous comment. However, I do foresee this affecting a lot of projects (I've already seen it in the handful that I've tested with). I agree the renaming approach is much better. |
☔ The latest upstream changes (presumably #5468) made this pull request unmergeable. Please resolve the merge conflicts. |
Hm, I don't fully understand the error. It looks like the rustc error message got interleaved with cargo's output:
Where that should say:
Is that a known issue? |
@bors: r+ Hm that looks like a werid spurious error, somehow a race but I'm not entirely sure how? |
📌 Commit 795f69b has been approved by |
Address autobins warning. Removes the large warning displayed if you build Cargo with itself (but adds a warning if you build with an older Cargo). Not sure which approach you prefer to address it, or if you want to do this later.
☀️ Test successful - status-appveyor, status-travis |
Just saw this PR (because of the merge conflict fallout it's had), and wanted to say: feel free to ping me if tweaks are required to |
Removes the large warning displayed if you build Cargo with itself (but adds a warning if you build with an older Cargo). Not sure which approach you prefer to address it, or if you want to do this later.