Print the full path to the generated documentation #5592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
This is looking good to me! I think there are some test failures though? |
|
@esteve any luck tracking down these test failures? |
|
Ok I'm gonna close this due to inactivity, but feel fre of course to resubmit! |
epage
added a commit
to epage/cargo
that referenced
this pull request
Oct 19, 2023
I've wanted something like this myself. I dislike using `--open` because I tend to move up to re-run my `cargo doc` run but then have to edit it to remove `--open`. Also makes it annoying when opening docs when `cargo doc` is wrapped by a tool like `make`. This was previously attempted in rust-lang#5592: - Unlike the request in rust-lang#5562, this aligns with rust-lang#5592 in always printing rather than using a flag as this seems generally useful - Unlike rust-lang#5592, this prints as an alternative to "Opening" to keep things light - Unlike rust-lang#5592, this prints afterwards as the link is only valid then Fixes rust-lang#5562
epage
added a commit
to epage/cargo
that referenced
this pull request
Oct 19, 2023
I've wanted something like this myself. I dislike using `--open` because I tend to move up to re-run my `cargo doc` run but then have to edit it to remove `--open`. Also makes it annoying when opening docs when `cargo doc` is wrapped by a tool like `make`. This was previously attempted in rust-lang#5592: - Unlike the request in rust-lang#5562, this aligns with rust-lang#5592 in always printing rather than using a flag as this seems generally useful - Unlike rust-lang#5592, this prints as an alternative to "Opening" to keep things light - Unlike rust-lang#5592, this prints afterwards as the link is only valid then Fixes rust-lang#5562
epage
added a commit
to epage/cargo
that referenced
this pull request
Oct 19, 2023
I've wanted something like this myself. I dislike using `--open` because I tend to move up to re-run my `cargo doc` run but then have to edit it to remove `--open`. Also makes it annoying when opening docs when `cargo doc` is wrapped by a tool like `make`. This was previously attempted in rust-lang#5592: - Unlike the request in rust-lang#5562, this aligns with rust-lang#5592 in always printing rather than using a flag as this seems generally useful - Unlike rust-lang#5592, this prints as an alternative to "Opening" to keep things light - Unlike rust-lang#5592, this prints afterwards as the link is only valid then Fixes rust-lang#5562
epage
added a commit
to epage/cargo
that referenced
this pull request
Oct 19, 2023
I've wanted something like this myself. I dislike using `--open` because I tend to move up to re-run my `cargo doc` run but then have to edit it to remove `--open`. Also makes it annoying when opening docs when `cargo doc` is wrapped by a tool like `make`. This was previously attempted in rust-lang#5592: - Unlike the request in rust-lang#5562, this aligns with rust-lang#5592 in always printing rather than using a flag as this seems generally useful - Unlike rust-lang#5592, this prints as an alternative to "Opening" to keep things light - Unlike rust-lang#5592, this prints afterwards as the link is only valid then Fixes rust-lang#5562
epage
added a commit
to epage/cargo
that referenced
this pull request
Oct 19, 2023
I've wanted something like this myself. I dislike using `--open` because I tend to move up to re-run my `cargo doc` run but then have to edit it to remove `--open`. Also makes it annoying when opening docs when `cargo doc` is wrapped by a tool like `make`. This was previously attempted in rust-lang#5592: - Unlike the request in rust-lang#5562, this aligns with rust-lang#5592 in always printing rather than using a flag as this seems generally useful - Unlike rust-lang#5592, this prints as an alternative to "Opening" to keep things light - Unlike rust-lang#5592, this prints afterwards as the link is only valid then Fixes rust-lang#5562
epage
added a commit
to epage/cargo
that referenced
this pull request
Oct 20, 2023
I've wanted something like this myself. I dislike using `--open` because I tend to move up to re-run my `cargo doc` run but then have to edit it to remove `--open`. Also makes it annoying when opening docs when `cargo doc` is wrapped by a tool like `make`. This was previously attempted in rust-lang#5592: - Unlike the request in rust-lang#5562, this aligns with rust-lang#5592 in always printing rather than using a flag as this seems generally useful - Unlike rust-lang#5592, this prints as an alternative to "Opening" to keep things light - Unlike rust-lang#5592, this prints afterwards as the link is only valid then Fixes rust-lang#5562
epage
added a commit
to epage/cargo
that referenced
this pull request
Oct 23, 2023
I've wanted something like this myself. I dislike using `--open` because I tend to move up to re-run my `cargo doc` run but then have to edit it to remove `--open`. Also makes it annoying when opening docs when `cargo doc` is wrapped by a tool like `make`. This was previously attempted in rust-lang#5592: - Unlike the request in rust-lang#5562, this aligns with rust-lang#5592 in always printing rather than using a flag as this seems generally useful - Unlike rust-lang#5592, this prints as an alternative to "Opening" to keep things light - Unlike rust-lang#5592, this prints afterwards as the link is only valid then Fixes rust-lang#5562
epage
added a commit
to epage/cargo
that referenced
this pull request
Oct 23, 2023
I've wanted something like this myself. I dislike using `--open` because I tend to move up to re-run my `cargo doc` run but then have to edit it to remove `--open`. Also makes it annoying when opening docs when `cargo doc` is wrapped by a tool like `make`. This was previously attempted in rust-lang#5592: - Unlike the request in rust-lang#5562, this aligns with rust-lang#5592 in always printing rather than using a flag as this seems generally useful - Unlike rust-lang#5592, this prints as an alternative to "Opening" to keep things light - Unlike rust-lang#5592, this prints afterwards as the link is only valid then Fixes rust-lang#5562
epage
added a commit
to epage/cargo
that referenced
this pull request
Oct 27, 2023
I've wanted something like this myself. I dislike using `--open` because I tend to move up to re-run my `cargo doc` run but then have to edit it to remove `--open`. Also makes it annoying when opening docs when `cargo doc` is wrapped by a tool like `make`. This was previously attempted in rust-lang#5592: - Unlike the request in rust-lang#5562, this aligns with rust-lang#5592 in always printing rather than using a flag as this seems generally useful - Unlike rust-lang#5592, this prints as an alternative to "Opening" to keep things light - Unlike rust-lang#5592, this prints afterwards as the link is only valid then Fixes rust-lang#5562
epage
added a commit
to epage/cargo
that referenced
this pull request
Oct 27, 2023
I've wanted something like this myself. I dislike using `--open` because I tend to move up to re-run my `cargo doc` run but then have to edit it to remove `--open`. Also makes it annoying when opening docs when `cargo doc` is wrapped by a tool like `make`. This was previously attempted in rust-lang#5592: - Unlike the request in rust-lang#5562, this aligns with rust-lang#5592 in always printing rather than using a flag as this seems generally useful - Unlike rust-lang#5592, this prints as an alternative to "Opening" to keep things light - Unlike rust-lang#5592, this prints afterwards as the link is only valid then Fixes rust-lang#5562
bors
added a commit
that referenced
this pull request
Oct 27, 2023
feat(doc): Print the generated docs links I've wanted something like this myself. I dislike using `--open` because I tend to move up to re-run my `cargo doc` run but then have to edit it to remove `--open`. Also makes it annoying when opening docs when `cargo doc` is wrapped by a tool like `make`. This was previously attempted in #5592: - Unlike the request in #5562, this aligns with #5592 in always printing rather than using a flag as this seems generally useful - Unlike #5592, this prints as an alternative to "Opening" to keep things light - Unlike #5592, this prints afterwards as the link is only valid then Fixes #5562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5562