Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --cap-lints in rustdoc. #5765

Merged
merged 1 commit into from
Jul 22, 2018
Merged

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jul 22, 2018

Fixes #5749.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@ehuss
Copy link
Contributor Author

ehuss commented Jul 22, 2018

cc @QuietMisdreavus

I'm not sure if intra_doc_link_resolution_failure is stable enough to use as a test, perhaps deny(missing_docs) is another option?

Also, I just wanted to verify that there is still a problem with the h2 crate? Is it something about documenting re-exported types from extern crates?

@alexcrichton
Copy link
Member

@bors: r+ thanks!

@bors
Copy link
Collaborator

bors commented Jul 22, 2018

📌 Commit c3b477d has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Jul 22, 2018

⌛ Testing commit c3b477d with merge ffcf739...

bors added a commit that referenced this pull request Jul 22, 2018
Support --cap-lints in rustdoc.

Fixes #5749.
@bors
Copy link
Collaborator

bors commented Jul 22, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing ffcf739 to master...

@bors bors merged commit c3b477d into rust-lang:master Jul 22, 2018
@QuietMisdreavus
Copy link
Member

@ehuss Yes, this won't fix the h2 crate, but it will prevent it from breaking downstream crates. I'm pretty sure the problem is rust-lang/rust#51684, but fixing that may take more time.

bors added a commit to rust-lang/rust that referenced this pull request Jul 28, 2018
[beta] Disable lints in rustdoc

The lint handling in rustdoc 1.28 is still incomplete so I think it would be best to disable it for the stable release. The main thing that's missing is that cargo doesn't cap lints for dependencies. This was fixed in master by #52354 and rust-lang/cargo#5765 but they haven't been backported. Additionally rustdoc is still emitting lints that are not on its whitelist #51661 (comment).

cc. @rust-lang/rustdoc
moshg pushed a commit to moshg/rust-std-ja that referenced this pull request Apr 4, 2020
[beta] Disable lints in rustdoc

The lint handling in rustdoc 1.28 is still incomplete so I think it would be best to disable it for the stable release. The main thing that's missing is that cargo doesn't cap lints for dependencies. This was fixed in master by #52354 and rust-lang/cargo#5765 but they haven't been backported. Additionally rustdoc is still emitting lints that are not on its whitelist rust-lang/rust#51661 (comment).

cc. @rust-lang/rustdoc
@ehuss ehuss added this to the 1.29.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo doc: pass --cap-lints allow when documenting dependencies
5 participants