now that we respect gitignore tests can be simplified #5810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ Nice! |
|
📌 Commit 7fc0dff has been approved by |
|
Sweet, more test simplification 👍 |
bors
added a commit
that referenced
this pull request
Jul 26, 2018
now that we respect gitignore tests can be simplified There are a lot of test that used a tempfile to avoid the fact that cargo would not init a git in the test folder. (or because they were copy/pasted from one that did.) Now that #5733 landed we can remove them all.
|
BTW I love your stats on the contributors graphs so far: dwijnand I love that you have net removed code! :-P |
|
Yep. I like to sum up my contributions as "net negative" 😉 |
|
💥 Test timed out |
|
@bors: retry |
|
@bors: are you still alive? |
|
@bors: retry |
|
@bors are you still there? |
|
🍰 Target acquired
|
|
@bors: r=alexcrichton |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 7fc0dff has been approved by |
bors
added a commit
that referenced
this pull request
Jul 27, 2018
now that we respect gitignore tests can be simplified There are a lot of test that used a tempfile to avoid the fact that cargo would not init a git in the test folder. (or because they were copy/pasted from one that did.) Now that #5733 landed we can remove them all.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of test that used a tempfile to avoid the fact that cargo would not init a git in the test folder. (or because they were copy/pasted from one that did.) Now that #5733 landed we can remove them all.