Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check target env in test when use targets #5859

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Conversation

jeizsm
Copy link
Contributor

@jeizsm jeizsm commented Aug 3, 2018

Hello. It also should check for target vendor but it's still unstable for some reason rust-lang/rust#29718

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Aug 3, 2018

📌 Commit b686606 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Aug 3, 2018

⌛ Testing commit b686606 with merge 67c4796...

bors added a commit that referenced this pull request Aug 3, 2018
check target env in test when use targets

Hello. It also should check for target vendor but it's still unstable for some reason rust-lang/rust#29718
@bors
Copy link
Contributor

bors commented Aug 3, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 67c4796 to master...

@bors bors merged commit b686606 into rust-lang:master Aug 3, 2018
@ehuss ehuss added this to the 1.29.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants