Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JSON with rustdoc. #5878

Merged
merged 2 commits into from
Aug 10, 2018
Merged

Support JSON with rustdoc. #5878

merged 2 commits into from
Aug 10, 2018

Commits on Aug 9, 2018

  1. Support JSON with rustdoc. 

    This allows `cargo doc --message-format=json` to actually work.

Note that this explicitly does not attempt to support it for doctests for
several reasons:
- `rustdoc --test --error-format=json` does not work for some reason.
- Since the lib is usually compiled before running rustdoc, warnings/errors
  will be emitted correctly by rustc.
- I'm unaware of any errors/warnings `rustdoc --test` is capable of producing
  assuming the code passed `rustc`.
- The compilation of the tests themselves do not support JSON.
- libtest does not output json, so it's utility is limited.
    @ehuss
    ehuss committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    f3faa97 View commit details
    Browse the repository at this point in the history

  2. Update for review comments.

    @ehuss
    ehuss committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    c28823f View commit details
    Browse the repository at this point in the history