Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cargo's internal hamcrest module #5945

Merged
merged 9 commits into from
Aug 29, 2018

Conversation

dwijnand
Copy link
Member

Fixes #5742

@rust-highfive
Copy link

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@ehuss
Copy link
Contributor

ehuss commented Aug 29, 2018

Would you mind updating the docs?

To run cargo, call the `cargo` method and use the `hamcrest` matchers to check
the output.

See the `hamcrest` module for other matchers like
`is_not(existing_file(path))`. This is not the actual hamcrest library, but
instead a lightweight subset of matchers that are used in cargo tests.

@alexcrichton
Copy link
Member

@bors: r+

😲

@bors
Copy link
Collaborator

bors commented Aug 29, 2018

📌 Commit a88a637 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Aug 29, 2018

⌛ Testing commit a88a637 with merge b1209f8...

bors added a commit that referenced this pull request Aug 29, 2018
Remove Cargo's internal `hamcrest` module

Fixes #5742
@bors
Copy link
Collaborator

bors commented Aug 29, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing b1209f8 to master...

@bors bors merged commit a88a637 into rust-lang:master Aug 29, 2018
@dwijnand dwijnand deleted the remove-hamcrest branch August 29, 2018 17:31
@ehuss ehuss added this to the 1.30.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test cleanup: Remove Cargo's internal hamcrest module
6 participants