Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to bash completion #6038

Merged
merged 2 commits into from
Sep 17, 2018
Merged

Minor updates to bash completion #6038

merged 2 commits into from
Sep 17, 2018

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Sep 17, 2018

  • Fix bash completion on mac.
  • Support arbitrary toolchain names.

For some bizarro reason, mac's bash doesn't like negative indexes,
even though its version of bash should support it.
@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 17, 2018

📌 Commit 3ae7f03 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Sep 17, 2018

⌛ Testing commit 3ae7f03 with merge 7b943bc...

bors added a commit that referenced this pull request Sep 17, 2018
Minor updates to bash completion

- Fix bash completion on mac.
- Support arbitrary toolchain names.
@bors
Copy link
Contributor

bors commented Sep 17, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 7b943bc to master...

@bors bors merged commit 3ae7f03 into rust-lang:master Sep 17, 2018
@ehuss ehuss added this to the 1.31.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants