Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: export repository information #6096

Merged
merged 2 commits into from
Oct 12, 2018

Conversation

mathstuf
Copy link
Contributor

The repository string is made available via the CARGO_PKG_REPOSITORY
environment variable similar to other metadata.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

The repository string is made available via the `CARGO_PKG_REPOSITORY`
environment variable similar to other metadata.
@mathstuf mathstuf force-pushed the export-repository-info branch from 3953359 to 07f872a Compare September 25, 2018 20:33
@alexcrichton alexcrichton added the T-cargo Team: Cargo label Sep 27, 2018
@alexcrichton
Copy link
Member

Looks great to me, thanks! Just to confirm with others let's...

@rfcbot fcp merge

@alexcrichton
Copy link
Member

Or perhaps just, @rust-lang/cargo any objections to adding this?

@Eh2406
Copy link
Contributor

Eh2406 commented Sep 27, 2018

Can we clarify in the docs that this is the repository field in your cargo.toml, and that we did not go rummaging around in you git/vc settings to find it. Because, a. we are not that creepy, and b. it may be incorrect.

@mathstuf
Copy link
Contributor Author

Also updated for homepage and description (though I would assume that cargo build doesn't go looking on Google for my homepage as well ;) ).

@mathstuf
Copy link
Contributor Author

Though cargo coming up with a description for my package could be helpful in some cases ;) .

@rfcbot
Copy link
Collaborator

rfcbot commented Sep 27, 2018

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 12, 2018

📌 Commit ae6b2f6 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Oct 12, 2018

⌛ Testing commit ae6b2f6 with merge 5fc8ac7...

bors added a commit that referenced this pull request Oct 12, 2018
build: export repository information

The repository string is made available via the `CARGO_PKG_REPOSITORY`
environment variable similar to other metadata.
@bors
Copy link
Contributor

bors commented Oct 12, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 5fc8ac7 to master...

@bors bors merged commit ae6b2f6 into rust-lang:master Oct 12, 2018
@mathstuf mathstuf deleted the export-repository-info branch October 14, 2018 17:08
@ehuss ehuss mentioned this pull request Mar 26, 2019
bors added a commit that referenced this pull request Mar 26, 2019
Some fingerprint cleanup.

Just a minor cleanup.

Move `CARGO_PKG_*` values from Metadata to Fingerprint (added in #3857).  Closes #6208.  This prevents stale artifacts from being left behind when these values change. Also tracks changes to the "repository" value (added in #6096).

Remove `edition` as a separate field. It is already tracked in `target`. This was required previously to #5816 which added per-target editions.

Also adds a helper to the testsuite to make globbing easier.
@ehuss ehuss added this to the 1.31.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-cargo Team: Cargo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants