Don't turn on edition lints for unfixed crates #6247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Cargo runs the risk of turning on the edition lints for crates which `cargo fix` isn't actually fixing, which means you'll get a huge deluge of lints that would otherwise be automatically fixable! Fix this situation by only enabling lints in the same cases that we're actually applying fixes. Closes rust-lang-nursery/rustfix#150
|
This improves the situation somewhat, but I think that not fixing path dependencies is still a bug. The Servo repository contains 67 crates. Fixing them one by one is not only tedious, but often doesn’t work because feature selection changes when building a crate directly rather than as a dependency of something that enables an optional feature. |
|
We can try to consider a change like |
|
Go, go incremental improvements. @bors: r+ |
|
📌 Commit 4f784a1 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 1, 2018
Don't turn on edition lints for unfixed crates Currently Cargo runs the risk of turning on the edition lints for crates which `cargo fix` isn't actually fixing, which means you'll get a huge deluge of lints that would otherwise be automatically fixable! Fix this situation by only enabling lints in the same cases that we're actually applying fixes. Closes rust-lang-nursery/rustfix#150
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
Nov 2, 2018
[beta]: Don't turn on edition lints for unfixed crates This is a backport of #6247
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 2, 2018
This commit updates Cargo to include rust-lang/cargo#6247 which contains a relatively serious fix for `cargo fix`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Cargo runs the risk of turning on the edition lints for crates
which
cargo fixisn't actually fixing, which means you'll get a hugedeluge of lints that would otherwise be automatically fixable! Fix this
situation by only enabling lints in the same cases that we're actually
applying fixes.
Closes rust-lang-nursery/rustfix#150