Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use allow-dirty option in cargo package to skip vcs checks #6280

Merged
merged 2 commits into from
Nov 29, 2018
Merged

use allow-dirty option in cargo package to skip vcs checks #6280

merged 2 commits into from
Nov 29, 2018

Commits on Nov 28, 2018

  1. add --no-vcs option to cargo package 

    If `cargo package` is run for a crate that is not version controlled in
a way that cargo expects, git2 will overreach upwards and grab a
irrelevant .git repo. This change adds `--no-vcs` as an option to
`cargo package` to prevent this.
    @zachreizner
    zachreizner committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    09cc2f2 View commit details
    Browse the repository at this point in the history

  2. use allow-dirty option in cargo package to skip vcs checks 

    To avoid introducing another flag, this change uses the `--allow-dirty`
flag to skip checking for vcs information. This is logical because a
user that passes that flag is indicating to `cargo package` that they
do not care about the state of vcs at that time.
    @zachreizner
    zachreizner committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    fd5fb6e View commit details
    Browse the repository at this point in the history