Commits on Nov 8, 2018

1. Timeout batch downloads, not each download …

   This commit switches the timeout logic implemented in rust-lang#6130 to timeout
   an entire batch of downloads instead of each download individually.
   Previously if *any* pending download didn't receive data in 30s we would
   time out, or if *any* pending download didn't receive 10 bytes in 30s we
   would time out. On very slow network connections this is highly likely
   to happen as a trickle of incoming bytes may not be spread equally
   amongst all connections, and not all connections may actually be active
   at any one point in time.
   
   The fix is to instead apply timeout logic for an entire batch of
   downloads. Only if zero total data isn't received in the timeout window
   do we time out. Or in other words, if any data for any download is
   receive we consider it as not being timed out. Similarly any progress on
   any download counts as progress towards our speed limit.
   
   Closes rust-lang#6284

   

   alexcrichton committed Nov 8, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 4e1e3f7
   • Browse repository at this point

   Copy the full SHA

   4e1e3f7 View commit details

   Browse the repository at this point in the history